Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

clientv3: embedded client #4709

Closed
heyitsanthony opened this issue Mar 7, 2016 · 7 comments
Closed

clientv3: embedded client #4709

heyitsanthony opened this issue Mar 7, 2016 · 7 comments

Comments

@heyitsanthony
Copy link
Contributor

In the future, some features implemented through the client may be "embedded" in the server for better performance (e.g., locks). Ideally, these features should work on the server without additional modification. Right now clientv3 expects to connect via gRPC to an etcd v3 server. In order to get good performance for the embedded case, the embedded client implementation should directly call the interfaces in api/v3rpc instead of going through grpc.

@timothysc
Copy link

/cc @smarterclayton fyi.

@heyitsanthony
Copy link
Contributor Author

done in #7444 via etcdserver/api/v3client

@xiang90
Copy link
Contributor

xiang90 commented Mar 14, 2017

@heyitsanthony Do we have an example or doc to talk about how to embed client?

@heyitsanthony
Copy link
Contributor Author

@xiang90 no. Is this a feature that should be advertised with examples or a doc? I think the usage is kind of straightforward, but an example could be added to v3client's doc.go...

@xiang90
Copy link
Contributor

xiang90 commented Mar 14, 2017

@heyitsanthony Initially an example would be good. If people start to ask about it, we can add a doc. What do you think?

@heyitsanthony
Copy link
Contributor Author

ok will add something to doc.go

@timothysc
Copy link

xref: kubernetes/kubernetes#43088

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

No branches or pull requests

4 participants