Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

*: update grpc-gateway and its import paths #5951

Merged
merged 5 commits into from
Jul 15, 2016
Merged

Conversation

gyuho
Copy link
Contributor

@gyuho gyuho commented Jul 15, 2016

No description provided.

@heyitsanthony
Copy link
Contributor

does this fix the broken json unmarshaling?

@gyuho
Copy link
Contributor Author

gyuho commented Jul 15, 2016

@heyitsanthony

Partially...

I have reliable way to reproduce. Found out it's an gogoproto issue or possibly we are generating the proto wrong way (gogofast instead of gofast). Once I figure it out, I will file an issue to gogoproto.

Either way we would need this update to support jsonpb from golang/protobuf.

@heyitsanthony
Copy link
Contributor

@gyuho This is vendoring a lot of new dependencies. Did grpc-gateway add a bunch of new deps (particularly bad, all the golang.org/x/tools/godoc deps) or what?

@gyuho
Copy link
Contributor Author

gyuho commented Jul 15, 2016

@heyitsanthony Yeah just noticed. I might have run godep wrong. Let me try again.

Thanks.

@gyuho gyuho changed the title *: update grpc-gateway and its import paths [DO NOT MERGE] *: update grpc-gateway and its import paths Jul 15, 2016
@gyuho gyuho changed the title [DO NOT MERGE] *: update grpc-gateway and its import paths *: update grpc-gateway and its import paths Jul 15, 2016
@gyuho
Copy link
Contributor Author

gyuho commented Jul 15, 2016

@heyitsanthony @xiang90 PTAL.

Actually our grpc-gateway already supports golang/jsonpb, so this won't fix the json marshalling issue (I already filed an upstream issue to gogoproto).

This only updates to new grpc-gateway import path.

@xiang90
Copy link
Contributor

xiang90 commented Jul 15, 2016

lgtm

@gyuho gyuho merged commit b26f1bb into etcd-io:master Jul 15, 2016
@gyuho gyuho deleted the vendor branch July 15, 2016 22:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants