-
Notifications
You must be signed in to change notification settings - Fork 9.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
*: update grpc-gateway and its import paths #5951
Conversation
does this fix the broken json unmarshaling? |
Partially... I have reliable way to reproduce. Found out it's an gogoproto issue or possibly we are generating the proto wrong way ( Either way we would need this update to support jsonpb from golang/protobuf. |
@gyuho This is vendoring a lot of new dependencies. Did grpc-gateway add a bunch of new deps (particularly bad, all the golang.org/x/tools/godoc deps) or what? |
@heyitsanthony Yeah just noticed. I might have run godep wrong. Let me try again. Thanks. |
@heyitsanthony @xiang90 PTAL. Actually our This only updates to new grpc-gateway import path. |
lgtm |
No description provided.