Add support for formating output of ls command in json or extended fo… #5999
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
lgtm. I think we need to change the commit message to |
|
Thanks for tip about the commit message. The failure on Semaphore doesn't look related. Is there a way to rerun? |
The ls command will check for and honor json or extended output formats. Fixes #5993
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change keeps the existing formatting for the default case and defers to printResponseKey when the user has explicitly specified something else via
--outputglobal option forls.Fixes #5993
I also could do something similar with
mkdirand andrmdirwhere they'd continue to behave the same as they do today unless the user has explicitly indicated otherwise with--output.