fix(server): avoid race conditions in Run/Stop #725
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -72,6 +73,7 @@ type PeerServer struct { | |||
| proxyClientURL string | |||
|
|
|||
| metrics *metrics.Bucket | |||
| mutex sync.Mutex | |||
There was a problem hiding this comment.
I think it is better to treat it as an anonymous field here.
|
Great work! |
- don't close ready channel until PeerServer is listening. avoids possible panic in Stop() if PeerServer is nil. - avoid data race in Run() (err variable was shared between 2 goroutines) - avoid data race in PeerServer Start/Stop (PeerServer.closeChan)
|
lgtm |
yichengq
added a commit
that referenced
this pull request
Apr 15, 2014
fix(server): avoid race conditions in Run/Stop
fanminshi
added a commit
to fanminshi/etcd
that referenced
this pull request
Feb 17, 2017
etcd process won't close on SIGINT. related issue etcd-io#725.
fanminshi
added a commit
to fanminshi/etcd
that referenced
this pull request
Feb 17, 2017
etcd process won't terminateon SIGINT but will on SIGTERM if test is run as a background process. related issue etcd-io#725.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
avoids possible panic in Stop() if PeerServer is nil.