Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

networking: set MTU on a VLAN subinterface for the bond using ignition config works #1412

Merged
merged 1 commit into from Jan 13, 2022

Conversation

HuijingHei
Copy link
Member

@HuijingHei HuijingHei commented Jan 11, 2022

Set MTU on a VLAN subinterface for the bond using ignition config and check

  • verify MTU on the bond matches config
  • verify MTU on the VLAN subinterface for the bond matches config
  • verify ip address on the VLAN subinterface for the bond matches config

The ignition config is generated using nm-initrd-generator according to
https://docs.fedoraproject.org/en-US/fedora-coreos/sysconfig-network-configuration/
$ kargs="bond=bond0:eth1,eth2:mode=active-backup,miimon=100:9000
ip=10.10.10.10::10.10.10.1:255.255.255.0:staticvlanbond:bond0.100:none:9000:
vlan=bond0.100:bond0"
$ /usr/libexec/nm-initrd-generator -s -- $kargs

@HuijingHei
Copy link
Member Author

This is the following PR for #1401

type=vlan
interface-name=bond0.100
[ethernet]
mac-address-blacklist=
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I know you used the doc to create it. A curiosity, make sense to have these items even with empty values?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @ravanelli , maybe no need to keep them, I will remove all items with empty values

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ehh - I would use exactly what was generated by nm-initrd-generator. This makes it easy to regenerate in the future.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does it need to remove line like uuid=d1171f53-2502-45dd-9199-698a778bf3bb?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

no - we don't need to remove the uuid lines I don't think.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just to confirm, this means we should remove the uuid lines?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No. I would think here that we don't need to remove any lines from the output of nm-initrd-generator.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK, thanks for your confirmation

ignition config works

Set MTU on a VLAN subinterface for the bond using ignition config and check
- verify MTU on the bond matches config
- verify MTU on the VLAN subinterface for the bond matches config
- verify ip address on the VLAN subinterface for the bond matches config

The ignition config is generated using nm-initrd-generator according to
https://docs.fedoraproject.org/en-US/fedora-coreos/sysconfig-network-configuration/
$ kargs="bond=bond0:eth1,eth2:mode=active-backup,miimon=100:9000 \
       ip=10.10.10.10::10.10.10.1:255.255.255.0:staticvlanbond:bond0.100:none:9000: \
       vlan=bond0.100:bond0"
$ /usr/libexec/nm-initrd-generator -s -- $kargs

Using kernel args to `configure MTU on a VLAN subinterface for the bond` refer to
coreos#1401
Copy link
Member

@dustymabe dustymabe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - though I would keep the NM config files exactly as they were generated by nm-initrd-generator.

@HuijingHei HuijingHei merged commit bf37b9c into coreos:testing-devel Jan 13, 2022
@HuijingHei HuijingHei deleted the mtu-on-bond-ignition branch January 13, 2022 02:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants