Add tool and GH workflow for adding fast-tracks and pins #1441
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We're going to add more functionality.
We're going to be updating lockfiles in other ways too.
jlebon
previously approved these changes
Jan 25, 2022
|
|
||
| pin = subcommands.add_parser('pin', description='Pin source RPMs.') | ||
| pin.add_argument('nvr', nargs='+', | ||
| help='NVR of SRPM to pin') |
There was a problem hiding this comment.
Minor/optional: since we're already importing koji, could be nice to also support Koji build URLs.
jlebon
previously approved these changes
Jan 27, 2022
For fast-tracks, take the Bodhi update, and for pins, take the SRPM NVR.
Verify that newly added pins and fast-tracks have dist tags that match the releasever from manifest.yaml, unless --ignore-dist-mismatch is specified.
This enforces existing policy.
The CI workflow will need it.
|
Updated! Also fixed handling of noarch packages, which were being ignored. |
Run `overrides.py {fast-track|pin}` and submit a PR. For now, only
handle one Bodhi update (for fast-track) or SRPM (for pin) per run.
Two runs are required when overriding both testing-devel and next-devel,
since next-devel might be on a different Fedora major.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rename and generalize
remove-graduated-overrides.py. Add subcommands for adding fast-tracks (from Bodhi update IDs or URLs) and pins (from SRPM NVRs). Unless--forceis specified, reject newly added overrides for the wrong Fedora major by comparing their dist tags to thereleaseverfrommanifest.yaml.Add a wrapper GitHub workflow that creates a PR to one branch, pinning one SRPM or fast-tracking one Bodhi update. More complex cases can use multiple workflow runs or manual PRs.