Revert "jenkins/config: fix oscontainer-secret formatting" #462
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit db97d56. Lessons learned: - `${oscontainer-secret/dockercfg}` expands to the *contents* of the path at `/run/secrets/oscontainer-secret/dockercfg` - therefore, `${readFile:${oscontainer-secret/dockercfg}}` will ask jcasc to read the file at `$CONTENTS`, which is of course not what we want. So the only issue was actually the path typo, which was fixed in coreos#461. As such, this is not a perfect revert. I also kept the updated documentation link and added some details to the comment.
|
No rush on this; I've already applied it to the cluster to verify that it worked (and it did!). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This reverts commit db97d56.
Lessons learned:
${oscontainer-secret/dockercfg}expands to the contents of thepath at
/run/secrets/oscontainer-secret/dockercfg${readFile:${oscontainer-secret/dockercfg}}will askjcasc to read the file at
$CONTENTS, which is of course not what wewant.
So the only issue was actually the path typo, which was fixed in #461.
As such, this is not a perfect revert. I also kept the updated
documentation link and added some details to the comment.