Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dracut: down the bonded interfaces properly (BZ#1789601) #148

Merged
merged 1 commit into from Jan 13, 2020

Conversation

@miabbott
Copy link
Contributor

miabbott commented Jan 13, 2020

Bonded interfaces that were taken down with just ip link set <if> down remained defined in /sys/class/net/bonding_masters. The
presence of these bonded interfaces in that sysfs location appears
to confuse NetworkManager during first boot and causes the bonded
interfaces to not come up correctly in the real root.

By removing the entries from bonding_masters, NetworkManager is
able to bring up the bonded interfaces correctly in the real root.

Fixes https://bugzilla.redhat.com/show_bug.cgi?id=1789601

Bonded interfaces that were taken down with just `ip link set <if>
down` remained defined in `/sys/class/net/bonding_masters`.  The
presence of these bonded interfaces in that `sysfs` location appears
to confuse `NetworkManager` during first boot and causes the bonded
interfaces to not come up correctly in the real root.

By removing the entries from `bonding_masters`, `NetworkManager` is
able to bring up the bonded interfaces correctly in the real root.

Fixes https://bugzilla.redhat.com/show_bug.cgi?id=1789601
@ashcrow ashcrow requested review from ashcrow, imcleod and dustymabe Jan 13, 2020
Copy link
Member

ashcrow left a comment

LGTM (cc @crawford)

@ashcrow ashcrow added the bug label Jan 13, 2020
bonds="$(cat /sys/class/net/bonding_masters)"
for b in ${bonds[@]}; do
down_interface ${b}
echo -"${b}" > /sys/class/net/bonding_masters

This comment has been minimized.

Copy link
@dustymabe

dustymabe Jan 13, 2020

Member

might be worth linking to the documentation about echo '-bond0' > /sys/class/net/bonding_masters being the appropriate interface. Or maybe we don't want to since that may incur another testing cycle.

Copy link
Member

dustymabe left a comment

LGTM

@imcleod

This comment has been minimized.

Copy link

imcleod commented Jan 13, 2020

LGTM

@ashcrow ashcrow merged commit 88b960b into coreos:spec2x Jan 13, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.