Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support conditional user creation #600

Closed
cgwalters opened this issue Jul 20, 2018 · 4 comments
Closed

Support conditional user creation #600

cgwalters opened this issue Jul 20, 2018 · 4 comments

Comments

@cgwalters
Copy link
Member

@cgwalters cgwalters commented Jul 20, 2018

Splitting this out of discussion here:

coreos/afterburn#90 (comment)

Today CL precreates a core user. Not all distributions will want to do that; I personally prefer the cloud-init semantic where it has a default user that's created dynamically if and only if you do not specify a different username.

I suspect for most people who are defining a different user with Ignition than core for CL, the core user is unused. And it could be a source of conflict if the machine is joined to a LDAP domain or whatever that happens to have a core user.

@ajeddeloh

This comment has been minimized.

Copy link
Contributor

@ajeddeloh ajeddeloh commented Jul 23, 2018

I don't really like the idea of conditional anything in Ignition; it's a declarative spec. We're not perfect at it, but it's what we aim for. What we can do is something akin to (and simpler than) the partition reuse semantics. This would enable a config to say core should not exist (and whether it should be deleted or Ignition should fail if it does) and that another user should exist.

Thoughts?

@bgilbert

This comment has been minimized.

Copy link
Member

@bgilbert bgilbert commented Jul 23, 2018

My understanding of the proposal is that Ignition would create the core user only if no other users are specified in the config. So the config would still be self-contained, just weirdly implicit.

But yeah, adding the ability to delete users does seem like a nice solution.

@ajeddeloh

This comment has been minimized.

Copy link
Contributor

@ajeddeloh ajeddeloh commented Mar 29, 2019

Given how we changed fcos to create core via the Ignition base config, Is this now part of #738? @cgwalters

@cgwalters

This comment has been minimized.

Copy link
Member Author

@cgwalters cgwalters commented Apr 3, 2019

Yeah, fine to close this in favor of #738 from my PoV.

@cgwalters cgwalters closed this Apr 3, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
3 participants
You can’t perform that action at this time.