Stabilize spec 3.2.0 #1103
Stabilize spec 3.2.0 #1103
Conversation
There was a problem hiding this comment.
The external kola test (ext.config.root-reprovision.luks) is failing, but that's understood as we move from a 3.2.0-experimental to 3.2.0 spec which would break this change.
--- FAIL: ext.config.root-reprovision.luks (11.86s)
harness.go:926: Cluster failed starting machines: machine cb8422ec-75ac-477a-ba4b-457f4e1c34ae entered emergency.target in initramfs
But overall, this change looks good to me. I used this doc for verification.
There was a problem hiding this comment.
Didn't dig into the details, but it looks reasonable to me!
Re. the breaking root reprovisioning tests, yeah that's unfortunate. Probably easiest to just merge on red here but sanity-check that the only tests that failed are the root reprovisioning ones, and locally verify that a cosa with the vendoring bumped to the stable spec and the tests updated to reference it does pass (or just manually boot up VMs directly with those Ignition configs really).
Once we do a new Ignition release, we'll have to merge the cosa version bump PR and the FCOS spec tweak and fast-track PR roughly at the same time.
arithx
force-pushed
the
3_2_0_stabilize
branch
2 times, most recently
from
db8aee5
to
6a5745f
Compare
|
Updated ⬆️ |
arithx
force-pushed
the
3_2_0_stabilize
branch
2 times, most recently
from
16662ea
to
75df5f1
Compare
|
Updated ⬆️ |
arithx
force-pushed
the
3_2_0_stabilize
branch
from
75df5f1
to
bea66ad
Compare
|
Merging over red per https://github.com/coreos/ignition/blob/master/docs/development.md#external-tests |
No description provided.