Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

oem: don't bind-mount docker into Google Cloud SDK container #439

Merged
merged 2 commits into from Sep 11, 2017

Conversation

Projects
None yet
2 participants
@bgilbert
Copy link
Member

bgilbert commented Sep 9, 2017

Bind-mounting the docker binary doesn't work with the torcx docker package, and google/cloud-sdk may ship its own docker binary in future.

For coreos/bugs#2112.

@bgilbert

This comment has been minimized.

Copy link
Member Author

bgilbert commented Sep 11, 2017

Good to merge. Want a rebase?

@dgonyeo

This comment has been minimized.

Copy link
Contributor

dgonyeo commented Sep 11, 2017

Yes please

bgilbert added some commits Sep 9, 2017

oem: drop gcutil alias
gcutil is no longer included in the Google Cloud SDK container.
oem: don't bind-mount docker into Google Cloud SDK container
Bind-mounting the docker binary doesn't work with the torcx docker
package, and google/cloud-sdk may ship its own docker binary in future.

@bgilbert bgilbert force-pushed the bgilbert:gce branch from 8a06b80 to 5cef79d Sep 11, 2017

@bgilbert

This comment has been minimized.

Copy link
Member Author

bgilbert commented Sep 11, 2017

Done.

@dgonyeo dgonyeo merged commit c966857 into coreos:master Sep 11, 2017

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@bgilbert bgilbert deleted the bgilbert:gce branch Sep 30, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.