Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

kola: Add --blacklist-test switch #1043

Merged
merged 1 commit into from Aug 14, 2019

Conversation

@ashcrow
Copy link
Contributor

commented Aug 14, 2019

When one or more --blacklist-test provided at run time any test that matches by name or pattern to the provided black list is not added to the list of tests to execute.

Example:

$ # Run all linux tests except the nfs ones
$ ./bin/kola --blacklist-test linux.nfs* run linux.*
$ # Run everything but linux.nfs.v3
$ ./bin/kola --blacklist-test linux.nfs.v3 run

/cc @miabbott

@ashcrow ashcrow requested review from arithx and ajeddeloh Aug 14, 2019

Show resolved Hide resolved kola/harness.go Outdated
Show resolved Hide resolved cmd/kola/options.go Outdated
@arithx

This comment has been minimized.

Copy link
Contributor

commented Aug 14, 2019

Would also be nice to update https://github.com/coreos/mantle#kola-run with your example of blacklisting a list of tests.

@ashcrow ashcrow force-pushed the ashcrow:blacklist-tests branch from bece5dc to f24278f Aug 14, 2019

@ashcrow

This comment has been minimized.

Copy link
Contributor Author

commented Aug 14, 2019

Updated per review

@arithx

arithx approved these changes Aug 14, 2019

Copy link
Contributor

left a comment

LGTM

@ashcrow ashcrow changed the title WIP: kola: Add --blacklist-test switch kola: Add --blacklist-test switch Aug 14, 2019

@ashcrow

This comment has been minimized.

Copy link
Contributor Author

commented Aug 14, 2019

Once this gets a second review it should be good to merge.

@yuqi-zhang
Copy link
Contributor

left a comment

One small nit, otherwise LGTM as well

Show resolved Hide resolved kola/harness.go
kola: Add --blacklist-test switch
When one or more --blacklist-test provided at run time any
test that matches by name or pattern to the provided black list
is not added to the list of tests to execute.

Example:
$ # Run all linux tests except the nfs ones
$ ./bin/kola --blacklist-test linux.nfs* run linux.*
$ # Run everything but linux.nfs.v3
$ ./bin/kola --blacklist-test linux.nfs.v3 run

Signed-off-by: Steve Milner <smilner@redhat.com>

@ashcrow ashcrow force-pushed the ashcrow:blacklist-tests branch from f24278f to 5c5708c Aug 14, 2019

@ashcrow

This comment has been minimized.

Copy link
Contributor Author

commented Aug 14, 2019

Updated

@arithx

arithx approved these changes Aug 14, 2019

@arithx

This comment has been minimized.

Copy link
Contributor

commented Aug 14, 2019

merging on green CI

@arithx arithx merged commit d0f16b4 into coreos:master Aug 14, 2019

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.