Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add feature template #1052

Merged
merged 2 commits into from Sep 6, 2019

Conversation

@ashcrow
Copy link
Member

commented Sep 4, 2019

Adds a feature template per meeting.

/cc @darkmuggle @ajeddeloh @lucab @vrutkovs @arithx

@arithx
arithx approved these changes Sep 4, 2019
@darkmuggle
Copy link

left a comment

Excellent, LGTM

@ashcrow

This comment has been minimized.

Copy link
Member Author

commented Sep 4, 2019

Travis failure is unrelated

@arithx

This comment has been minimized.

Copy link
Contributor

commented Sep 4, 2019

Testing a fix in #1053 to unblock this

@bgilbert

This comment has been minimized.

Copy link
Member

commented Sep 4, 2019

This will cause the "New issue" button to present a UI similar to this, but with only one row. So if we're adding a feature template, we should add a bug template too.

@arithx

This comment has been minimized.

Copy link
Contributor

commented Sep 4, 2019

#1053 is merged, if you rebase on top of current master the travis failure should go away (as it will now correctly use the cached vendor/ directory instead of attempting to fetch vendored libraries)

ashcrow added 2 commits Sep 4, 2019
Add feature template
Signed-off-by: Steve Milner <smilner@redhat.com>
Add bug template
Signed-off-by: Steve Milner <smilner@redhat.com>

@ashcrow ashcrow force-pushed the ashcrow:issue-template branch from 5ebf9a1 to b877d6c Sep 5, 2019

@ashcrow

This comment has been minimized.

Copy link
Member Author

commented Sep 5, 2019

Rebased and added

@arithx
arithx approved these changes Sep 5, 2019
@lucab lucab referenced this pull request Sep 5, 2019
@bgilbert bgilbert referenced this pull request Sep 5, 2019

@arithx arithx merged commit 688768a into coreos:master Sep 6, 2019

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.