-
Notifications
You must be signed in to change notification settings - Fork 77
gcp: Add UEFI_COMPATIBLE and SECURE_BOOT #1060
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Haven't played much with GCP, but this looks reasonable to me!
|
This gets me a vTPM, though for some reason it still doesn't seem to be booting in UEFI mode with Secure Boot. |
| &compute.GuestOsFeature{ | ||
| Type: "UEFI_COMPATIBLE", | ||
| }, | ||
| &compute.GuestOsFeature{ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@bgilbert do you know if CL+GCE supports this?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
UEFI should work. Secure Boot does not.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
SECURE_BOOT will need to condition on the OS.
|
Actually, let's condition both flags on the OS. We shouldn't change the CL image configuration at this point. |
|
How do we condition on the OS? Does that imply adding a new CLI argument here and passing it from cosa? (When can we create a |
plume, which we should be using, already knows what OS it's releasing. For ore we'd have to add a CLI argument. |
For FCOS we support both. Mainly I'm adding these because they seem to be prerequisites for accessing the "vTPM" which is part of the "Shielded Cloud" umbrella. We want access to the vTPM to enable support for LUKS bound to vTPM for example. Also, for OpenShift, I think at some point we want to enable using TPM as a "strong identity" for nodes.
947b6fc to
01ef893
Compare
|
OK updated to pass an arg.
Yeah...it just hurts my head to even try to think about adding a fourth case for plume. It's really the opposite direction for RHCOS anyways, where the "release" is not directly to users but through the installer or a release image. |
We talked about this OOB and are going to start preparing to branch mantle for CL. |
|
We had some OOB discussions around whether this should be gated post branching for CL. There were some concerns raised about whether or not Fedora Cloud Base would have similar restrictions on those options. Going to merge this as is and we can revisit it at a later date. |
For FCOS we support both. Mainly I'm adding these because
they seem to be prerequisites for accessing the "vTPM" which
is part of the "Shielded Cloud" umbrella. We want access to the vTPM
to enable support for LUKS bound to vTPM for example. Also,
for OpenShift, I think at some point we want to enable using TPM
as a "strong identity" for nodes.