Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

*: add aliyun #1066

Merged
merged 6 commits into from Oct 10, 2019

Conversation

@arithx
Copy link
Contributor

commented Oct 2, 2019

No description provided.

arithx added 2 commits Oct 2, 2019
When importing the dependencies for aliyun `x/crypto` was forcibly
bumped which had breaking behavior of requiring the `HostKeyCallback`
field of `ssh.ClientConfig` to not be nil (resulting in a panic if nil).
Copy link
Member

left a comment

Looks sane from a quick scan!

auth/aliyun.go Outdated Show resolved Hide resolved
Adds a new auth provider for aliyun which will parse the official CLI
configuration file from `~/.aliyun/config.json`
@arithx arithx force-pushed the arithx:aliyun branch from f6fdae1 to 15bc3a8 Oct 2, 2019
Adds the aliyun platform API; initially only supports a select set of
ECS & OSS calls relating to importing & copying images.
@arithx arithx force-pushed the arithx:aliyun branch from 15bc3a8 to 2d5c265 Oct 9, 2019
@arithx arithx marked this pull request as ready for review Oct 9, 2019
@arithx

This comment has been minimized.

Copy link
Contributor Author

commented Oct 9, 2019

Tested & marked ready for review

@ashcrow ashcrow referenced this pull request Oct 9, 2019
5 of 6 tasks complete
cmd/ore/aliyun/create.go Outdated Show resolved Hide resolved
cmd/ore/aliyun/create.go Outdated Show resolved Hide resolved
network/ssh.go Show resolved Hide resolved
Copy link
Member

left a comment

Two nits but LGTM

arithx added 2 commits Oct 2, 2019
Adds a new aliyun command and 3 new subcommands underneath it all
relating to image creation, copying, and deletion.
@arithx arithx force-pushed the arithx:aliyun branch from 2d5c265 to 2c3ed17 Oct 10, 2019
@arithx

This comment has been minimized.

Copy link
Contributor Author

commented Oct 10, 2019

Renamed the create-image source file, merging on green.

@arithx arithx merged commit d1e4435 into coreos:master Oct 10, 2019
1 check passed
1 check passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@arithx arithx deleted the arithx:aliyun branch Oct 10, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.