Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

kola/tests/crio/crio: Add pods and service restart test #1070

Merged
merged 1 commit into from Oct 11, 2019

Conversation

@ashcrow
Copy link
Member

commented Oct 3, 2019

Adds a test that verifies pods continue when the crio service is restarted.

See: https://access.redhat.com/solutions/3825511

@ashcrow ashcrow requested review from vrutkovs and arithx Oct 3, 2019
kola/tests/crio/crio.go Outdated Show resolved Hide resolved
@cgwalters

This comment has been minimized.

Copy link
Member

commented Oct 3, 2019

Is there a specific bug that motivated adding this? Would be good to link it if so.

@ashcrow

This comment has been minimized.

Copy link
Member Author

commented Oct 3, 2019

Is there a specific bug that motivated adding this? Would be good to link it if so.

There is. Good call, I'll add it.

@ashcrow ashcrow force-pushed the ashcrow:kola-crio-restart-test branch 3 times, most recently from accfac1 to 11f299c Oct 3, 2019
@cgwalters

This comment has been minimized.

Copy link
Member

commented Oct 10, 2019

Is this still WIP? Offhand it seems OK to me, though long term I'd like us to run crio's upstream tests, and ensure that this test lives there.

And just a sanity check since we don't have any useful CI on this repo yet - did you run this locally against rhcos-4.3 on...qemu?

@ashcrow

This comment has been minimized.

Copy link
Member Author

commented Oct 10, 2019

Is this still WIP? Offhand it seems OK to me, though long term I'd like us to run crio's upstream tests, and ensure that this test lives there.

It's WIP. I've been running into issues getting it to run due to no network in qemu.

And just a sanity check since we don't have any useful CI on this repo yet - did you run this locally against rhcos-4.3 on...qemu?

I have not yet.

@cgwalters

This comment has been minimized.

Copy link
Member

commented Oct 10, 2019

Did you try rebasing on #1072 ?

@ashcrow

This comment has been minimized.

Copy link
Member Author

commented Oct 10, 2019

Did you try rebasing on #1072 ?

Ah! No I haven't. But I will 🙂

@ashcrow

This comment has been minimized.

Copy link
Member Author

commented Oct 10, 2019

Did you try rebasing on #1072 ?

Ah! No I haven't. But I will slightly_smiling_face

Rebasing was super helpful. The test fails, but now I can better debug why. Thank you @cgwalters .

Adds a test that verifies pods continue when the crio service
is restarted.

See: https://access.redhat.com/solutions/3825511

Signed-off-by: Steve Milner <smilner@redhat.com>
@ashcrow ashcrow force-pushed the ashcrow:kola-crio-restart-test branch from 11f299c to a62ae6c Oct 10, 2019
@ashcrow

This comment has been minimized.

Copy link
Member Author

commented Oct 10, 2019

$ sudo ./bin/kola --platform qemu-unpriv --distro rhcos --ignition-version v2 --ssh-on-test-failure --qemu-image ./rhcos-42.80.20191008.0-qemu.qcow2 run crio.base
=== RUN   crio.base
=== RUN   crio.base/crio-info
=== RUN   crio.base/pod-continues-during-service-restart
=== RUN   crio.base/networks-reliably
--- PASS: crio.base (96.43s)
    --- PASS: crio.base/crio-info (0.12s)
    --- PASS: crio.base/pod-continues-during-service-restart (40.91s)
            cluster.go:122: STEP 1: FROM scratch
            cluster.go:122: STEP 2: COPY . /
            cluster.go:122: STEP 3: COMMIT localhost/sleep
            cluster.go:122: Getting image source signatures
            cluster.go:122: Copying blob sha256:c3ccafd1a83fab850dc9b4599017c171a8f8847518426adaa409ab6e5df89922
            cluster.go:122: Copying config sha256:7f37a57e6fa8f0d4fec7a418cf188843122e30bc53d6b8c02c4aca0cfd8a758f
            cluster.go:122: Writing manifest to image destination
            cluster.go:122: Storing signatures
    --- PASS: crio.base/networks-reliably (27.27s)
            cluster.go:122: STEP 1: FROM scratch
            cluster.go:122: STEP 2: COPY . /
            cluster.go:122: STEP 3: COMMIT localhost/ping
            cluster.go:122: Getting image source signatures
            cluster.go:122: Copying blob sha256:67737d345c27d045d7cc3ebb0c5f2a5131ced2f644dd2bd454fce214c46c92bd
            cluster.go:122: Copying config sha256:6a66872b1e682e0c6b38a7149f39776b0807473d4053ff9cee762d46ddb13413
            cluster.go:122: Writing manifest to image destination
            cluster.go:122: Storing signatures
PASS, output in _kola_temp/qemu-unpriv-2019-10-10-1309-27108
@ashcrow ashcrow changed the title WIP: kola/tests/crio/crio: Add pods and service restart test kola/tests/crio/crio: Add pods and service restart test Oct 10, 2019
@ashcrow

This comment has been minimized.

Copy link
Member Author

commented Oct 10, 2019

Ready for review

@arithx
arithx approved these changes Oct 10, 2019
Copy link
Contributor

left a comment

One question, otherwise LGTM

"directories": [{
"filesystem": "root",
"path": "/tmp/test",
"mode": 511

This comment has been minimized.

Copy link
@arithx

arithx Oct 10, 2019

Contributor

Does this need to be 0777?

This comment has been minimized.

Copy link
@ashcrow

ashcrow Oct 10, 2019

Author Member

It probably doesn't HAVE to be 0777 ... 0755 would probably be fine as well.

This comment has been minimized.

Copy link
@arithx

arithx Oct 10, 2019

Contributor

I'm okay with it either way. Feel free to change or just merge

@cgwalters

This comment has been minimized.

Copy link
Member

commented Oct 10, 2019

sudo ./bin/kola --platform qemu-unpriv

Side note; no reason to use sudo with qemu-unpriv right? Also today, cosa kola when invoked as non-root will automatically do the right thing.

@ashcrow ashcrow merged commit 6faf458 into coreos:master Oct 11, 2019
1 check passed
1 check passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.