kola/tests/crio/crio: Add pods and service restart test #1070

ashcrow · 2019-10-03T18:20:57Z

Adds a test that verifies pods continue when the crio service is restarted.

See: https://access.redhat.com/solutions/3825511

kola/tests/crio/crio.go

cgwalters · 2019-10-03T19:20:03Z

Is there a specific bug that motivated adding this? Would be good to link it if so.

ashcrow · 2019-10-03T19:36:46Z

Is there a specific bug that motivated adding this? Would be good to link it if so.

There is. Good call, I'll add it.

cgwalters · 2019-10-10T14:28:04Z

Is this still WIP? Offhand it seems OK to me, though long term I'd like us to run crio's upstream tests, and ensure that this test lives there.

And just a sanity check since we don't have any useful CI on this repo yet - did you run this locally against rhcos-4.3 on...qemu?

ashcrow · 2019-10-10T14:51:50Z

Is this still WIP? Offhand it seems OK to me, though long term I'd like us to run crio's upstream tests, and ensure that this test lives there.

It's WIP. I've been running into issues getting it to run due to no network in qemu.

And just a sanity check since we don't have any useful CI on this repo yet - did you run this locally against rhcos-4.3 on...qemu?

I have not yet.

cgwalters · 2019-10-10T14:55:52Z

Did you try rebasing on #1072 ?

ashcrow · 2019-10-10T15:03:38Z

Did you try rebasing on #1072 ?

Ah! No I haven't. But I will 🙂

ashcrow · 2019-10-10T16:11:12Z

Did you try rebasing on #1072 ?

Ah! No I haven't. But I will slightly_smiling_face

Rebasing was super helpful. The test fails, but now I can better debug why. Thank you @cgwalters .

Adds a test that verifies pods continue when the crio service is restarted. See: https://access.redhat.com/solutions/3825511 Signed-off-by: Steve Milner <smilner@redhat.com>

ashcrow · 2019-10-10T17:18:41Z

$ sudo ./bin/kola --platform qemu-unpriv --distro rhcos --ignition-version v2 --ssh-on-test-failure --qemu-image ./rhcos-42.80.20191008.0-qemu.qcow2 run crio.base
=== RUN   crio.base
=== RUN   crio.base/crio-info
=== RUN   crio.base/pod-continues-during-service-restart
=== RUN   crio.base/networks-reliably
--- PASS: crio.base (96.43s)
    --- PASS: crio.base/crio-info (0.12s)
    --- PASS: crio.base/pod-continues-during-service-restart (40.91s)
            cluster.go:122: STEP 1: FROM scratch
            cluster.go:122: STEP 2: COPY . /
            cluster.go:122: STEP 3: COMMIT localhost/sleep
            cluster.go:122: Getting image source signatures
            cluster.go:122: Copying blob sha256:c3ccafd1a83fab850dc9b4599017c171a8f8847518426adaa409ab6e5df89922
            cluster.go:122: Copying config sha256:7f37a57e6fa8f0d4fec7a418cf188843122e30bc53d6b8c02c4aca0cfd8a758f
            cluster.go:122: Writing manifest to image destination
            cluster.go:122: Storing signatures
    --- PASS: crio.base/networks-reliably (27.27s)
            cluster.go:122: STEP 1: FROM scratch
            cluster.go:122: STEP 2: COPY . /
            cluster.go:122: STEP 3: COMMIT localhost/ping
            cluster.go:122: Getting image source signatures
            cluster.go:122: Copying blob sha256:67737d345c27d045d7cc3ebb0c5f2a5131ced2f644dd2bd454fce214c46c92bd
            cluster.go:122: Copying config sha256:6a66872b1e682e0c6b38a7149f39776b0807473d4053ff9cee762d46ddb13413
            cluster.go:122: Writing manifest to image destination
            cluster.go:122: Storing signatures
PASS, output in _kola_temp/qemu-unpriv-2019-10-10-1309-27108

ashcrow · 2019-10-10T17:19:06Z

Ready for review

arithx

One question, otherwise LGTM

arithx · 2019-10-10T19:03:16Z

kola/tests/crio/crio.go

+	"directories": [{
+		"filesystem": "root",
+		"path": "/tmp/test",
+		"mode": 511


Does this need to be 0777?

It probably doesn't HAVE to be 0777 ... 0755 would probably be fine as well.

I'm okay with it either way. Feel free to change or just merge

cgwalters · 2019-10-10T19:53:09Z

sudo ./bin/kola --platform qemu-unpriv

Side note; no reason to use sudo with qemu-unpriv right? Also today, cosa kola when invoked as non-root will automatically do the right thing.

ashcrow added the component/kola label Oct 3, 2019

ashcrow requested review from vrutkovs and arithx October 3, 2019 18:20

arithx reviewed Oct 3, 2019

View reviewed changes

kola/tests/crio/crio.go Outdated Show resolved Hide resolved

ashcrow force-pushed the kola-crio-restart-test branch 3 times, most recently from accfac1 to 11f299c Compare October 8, 2019 18:28

kola/tests/crio/crio: Add pods and service restart test

a62ae6c

Adds a test that verifies pods continue when the crio service is restarted. See: https://access.redhat.com/solutions/3825511 Signed-off-by: Steve Milner <smilner@redhat.com>

ashcrow force-pushed the kola-crio-restart-test branch from 11f299c to a62ae6c Compare October 10, 2019 17:18

ashcrow changed the title ~~WIP: kola/tests/crio/crio: Add pods and service restart test~~ kola/tests/crio/crio: Add pods and service restart test Oct 10, 2019

arithx approved these changes Oct 10, 2019

View reviewed changes

ashcrow merged commit 6faf458 into coreos:master Oct 11, 2019

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

kola/tests/crio/crio: Add pods and service restart test #1070

kola/tests/crio/crio: Add pods and service restart test #1070

ashcrow commented Oct 3, 2019 •

edited

cgwalters commented Oct 3, 2019

ashcrow commented Oct 3, 2019

cgwalters commented Oct 10, 2019

ashcrow commented Oct 10, 2019

cgwalters commented Oct 10, 2019

ashcrow commented Oct 10, 2019

ashcrow commented Oct 10, 2019

ashcrow commented Oct 10, 2019

ashcrow commented Oct 10, 2019

arithx left a comment

arithx Oct 10, 2019

ashcrow Oct 10, 2019

arithx Oct 10, 2019

cgwalters commented Oct 10, 2019 •

edited

kola/tests/crio/crio: Add pods and service restart test #1070

kola/tests/crio/crio: Add pods and service restart test #1070

Conversation

ashcrow commented Oct 3, 2019 • edited

cgwalters commented Oct 3, 2019

ashcrow commented Oct 3, 2019

cgwalters commented Oct 10, 2019

ashcrow commented Oct 10, 2019

cgwalters commented Oct 10, 2019

ashcrow commented Oct 10, 2019

ashcrow commented Oct 10, 2019

ashcrow commented Oct 10, 2019

ashcrow commented Oct 10, 2019

arithx left a comment

Choose a reason for hiding this comment

arithx Oct 10, 2019

Choose a reason for hiding this comment

ashcrow Oct 10, 2019

Choose a reason for hiding this comment

arithx Oct 10, 2019

Choose a reason for hiding this comment

cgwalters commented Oct 10, 2019 • edited

ashcrow commented Oct 3, 2019 •

edited

cgwalters commented Oct 10, 2019 •

edited