Skip to content
This repository has been archived by the owner on May 7, 2021. It is now read-only.

Check endianness when getting the qemu port #1073

Merged
merged 1 commit into from Oct 7, 2019

Conversation

Prashanth684
Copy link

When getting the qemu port, the list of connections in /proc/net/tcp is checked and the localhost address
is compares against. Ensure that the correct value is used for big and little endian arches

Potential fix for: #1068

platform/flight.go Outdated Show resolved Hide resolved
Copy link
Member

@cgwalters cgwalters left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall LGTM

platform/platform.go Outdated Show resolved Hide resolved
When getting the qemu port, the list of connections in /proc/net/tcp is checked and the localhost address
is compares against. Ensure that the correct value is used for big and little endian arches
Copy link
Contributor

@arithx arithx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@arithx arithx merged commit afffc46 into coreos:master Oct 7, 2019
@Prashanth684 Prashanth684 deleted the mantle-endian branch October 8, 2019 18:07
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants