Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

thanos: upgrade dependency and default to v0.5.0 #2633

Merged
merged 2 commits into from Jun 7, 2019
Merged

thanos: upgrade dependency and default to v0.5.0 #2633

merged 2 commits into from Jun 7, 2019

Conversation

abursavich
Copy link
Contributor

Per #2623 (comment) and #2629 (comment), this upgrades the thanos dependency and default to v0.5.0.

github.com/prometheus/client_golang v0.9.2
github.com/prometheus/prometheus v0.0.0-20190328180107-4d60eb36dcbe
github.com/prometheus/client_golang v0.9.3-0.20190127221311-3c4408c8b829
github.com/prometheus/prometheus v2.9.2+incompatible
Copy link
Contributor Author

@abursavich abursavich Jun 6, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

NOTE: I hadn't seen the +incompatible suffix before and it worried me for a minute, but it's okay: https://github.com/golang/go/wiki/Modules#can-a-module-consume-a-v2-package-that-has-not-opted-into-modules-what-does-incompatible-mean

@abursavich
Copy link
Contributor Author

cc @brancz

@brancz
Copy link
Contributor

brancz commented Jun 6, 2019

Thank you so much for your awesome contributions! lgtm on green 👍

@abursavich
Copy link
Contributor Author

I have no idea why that test would fail that way... If it's a real issue and not just a flaky test, it may be a few days before I can get to it.

@brancz
Copy link
Contributor

brancz commented Jun 7, 2019

That was a known flake. Restarted.

@brancz brancz merged commit 0fee93e into prometheus-operator:master Jun 7, 2019
@brancz
Copy link
Contributor

brancz commented Jun 7, 2019

Thanks lgtm 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants