New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

grafana-watcher login fixes #289

Merged
merged 2 commits into from Apr 18, 2017

Conversation

Projects
None yet
3 participants
@sjuxax
Contributor

sjuxax commented Apr 15, 2017

There is a potential race condition when the grafana manifests are applied where the credentials may not be applied prior to the deployment, which depends on them. I believe this was the cause of some issues I had with grafana-watcher.

There is now a helpful error message when grafana-watcher cannot log in, and grafana-credentials.yaml are applied prior to other grafana manifests to prevent weird login conditions like the one I experienced.

sjuxax added some commits Apr 15, 2017

Ensure that grafana-credentials are created first. ...
Without this, a race condition may occur, preventing grafana-watcher
from logging in to grafana.
@coreosbot

This comment has been minimized.

Collaborator

coreosbot commented Apr 15, 2017

Can one of the admins verify this patch?

2 similar comments
@coreosbot

This comment has been minimized.

Collaborator

coreosbot commented Apr 15, 2017

Can one of the admins verify this patch?

@coreosbot

This comment has been minimized.

Collaborator

coreosbot commented Apr 15, 2017

Can one of the admins verify this patch?

@fabxc

This comment has been minimized.

Contributor

fabxc commented Apr 18, 2017

Thanks! LGTM.

@fabxc fabxc merged commit 732a3b8 into coreos:master Apr 18, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment