libpriv/scripts: Replace crypto-policies lua script #2136
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The latest crypto-policies package changed recently to dynamically set the policy at install time so that if FIPS is enabled, the selected backend is `FIPS`: https://src.fedoraproject.org/rpms/crypto-policies/c/9b9c9f7378c3fd375b9a08d5283c530a51a5de34?branch=master This doesn't really make sense for us though since the compose server configuration should be decoupled from the installroot. (More generally, this also affects e.g. `yum install --installroot`). Override the script for now so that we always select the `DEFAULT` policy. We'll discuss with upstream to see what the right solution is there. This also works around the fact that rpm-ostree doesn't yet implement Lua (coreos#749). Related: https://bugzilla.redhat.com/show_bug.cgi?id=1847454 Resolves: coreos/fedora-coreos-tracker#540
|
|
To be explicit: I think the main issue here is that the behaviour expressed by the scriptlet doesn't match our model. So even if we did support lua, I think we'd probably want to tweak it. |
The CoreOS CI shared lib sets `HOME` to the workspace: coreos/coreos-ci-lib@a81bfab and there's no easy way for it to detect when `HOME` is correctly set: coreos/coreos-ci-lib@8574f04 coreos/coreos-ci-lib@853d5fd For now, just work around this until we have a cleaner solution. (Though it makes sense overall to uses `$HOME` anyway instead of hardcoding `/root`).
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: cgwalters, jlebon The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The latest crypto-policies package changed recently to dynamically set
the policy at install time so that if FIPS is enabled, the selected
backend is
FIPS:https://src.fedoraproject.org/rpms/crypto-policies/c/9b9c9f7378c3fd375b9a08d5283c530a51a5de34?branch=master
This doesn't really make sense for us though since the compose server
configuration should be decoupled from the installroot. (More generally,
this also affects e.g.
yum install --installroot).Override the script for now so that we always select the
DEFAULTpolicy. We'll discuss with upstream to see what the right solution is
there.
This also works around the fact that rpm-ostree doesn't yet implement
Lua (#749).
Related: https://bugzilla.redhat.com/show_bug.cgi?id=1847454
Resolves: coreos/fedora-coreos-tracker#540