This repository was archived by the owner on Sep 18, 2020. It is now read-only.
prod_image_util: move pam.d contents, not the directory #558
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| # Move the PAM configuration into /usr | ||
| sudo mv ${root_fs_dir}/etc/pam.d ${root_fs_dir}/usr/lib | ||
| sudo mkdir -p ${root_fs_dir}/usr/lib/pam.d | ||
| sudo mv -n ${root_fs_dir}/etc/pam.d/* ${root_fs_dir}/usr/lib/pam.d/ |
Contributor
There was a problem hiding this comment.
Why no-clobber? Should we empty this directory before doing the move?
Contributor
Author
There was a problem hiding this comment.
The directory isn't and shouldn't be empty following the new baselayout version. I tossed in -n on the off chance that something weird happened. What I really want is "fail if you would have clobbered" but there isn't any such option.
Contributor
Author
There was a problem hiding this comment.
oh, I could do rmdir and that'll be that sanity check
The baselayout package now creates and installs /usr/lib/pam.d, causing mv to fail. Move the contents instead which is happy with both versions.
Contributor
|
LGTM |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The baselayout package now creates and installs /usr/lib/pam.d, causing
mv to fail. Move the contents instead which is happy with both versions.