Fix #99. Break up big queries into little ones #100

Merged
merged 3 commits into from Aug 6, 2012

Conversation

Projects
None yet
2 participants
Contributor

pixelcort commented Aug 3, 2012

Also does the filtering out in code in one of them.

This fixes #99 where if there are too many ids, these queries can fail to work.

Cortland Klein Fix #99. Break up big queries into little ones
Also does the filtering out in code in one of them
5af2659
Contributor

pixelcort commented Aug 4, 2012

Whoops, looks like there's a typo in this fix. Hold off on integrating it; I'll update this once I commit the fix into this PR.

Cortland Klein added some commits Aug 4, 2012

Contributor

pixelcort commented Aug 4, 2012

Okay this looks good now and is probably ready for pulling in.

There's a second O(n^2) performance problem with syncing locally deleted records, but I think that's a separate issue as it appears to also be there before these fixes.

@zefhemel zefhemel pushed a commit that referenced this pull request Aug 6, 2012

Zef Hemel Merge pull request #100 from pixelcort/fix99
Fix #99. Break up big queries into little ones
ca38084

@zefhemel zefhemel merged commit ca38084 into coresmart:master Aug 6, 2012

Collaborator

zefhemel commented Aug 6, 2012

Thanks!

pixelcort deleted the pixelcort:fix99 branch Dec 29, 2013

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment