Fixed removing local (_new) objects #89

Merged
merged 1 commit into from Apr 25, 2013

Conversation

Projects
None yet
2 participants
Contributor

superquadratic commented Mar 30, 2012

If an object was created, added and removed without flushing in between, it was still persisted. Fixed by directly removing _new objects from the trackedObjects array.

PLEASE NOTE: This change touches sync functionality, by moving the this.objectsRemoved.push() call into the else clause. As far as I can tell, this seems to be the right thing to do. However, I wasn't able to run the sync tests on my Windows setup -- so please only merge this after running the sync tests.

Fixed removing local (_new) objects
If an object was created, added and removed without flushing in between, it
was still persisted. Fixed by directly removing _new objects from the
trackedObjects array.

zefhemel added a commit that referenced this pull request Apr 25, 2013

Merge pull request #89 from doo/local_object_removal
Fixed removing local (_new) objects

@zefhemel zefhemel merged commit 61629e4 into coresmart:master Apr 25, 2013

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment