CLink emit click's argument contains the mouse events #207
Conversation
W/o providing the (native) mouse event no consumer can react accordingly. With this change the mouse event is emitted as first argument in the click event.
gfoidl
changed the title
|
This PR has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions |
|
Please don't close. |
|
@xidedix IMO your suggestion makes more sense, as the |
|
This PR has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions |
|
Please don't close, merge instead 😉 |
|
This PR has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions |
|
|
This PR has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions |
|
|
This PR has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions |
|
|
This PR has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions |
|
@mrholek another one that the bot closed, but it should get addressed instead. |
| const handleClick = () => { | ||
| emit('click', props.href) | ||
| const handleClick = (mouseEvent: MouseEvent) => { | ||
| emit('click', props.href, mouseEvent) |
There was a problem hiding this comment.
For the vue-router this must be
emit('click', mouseEvent, props.href)
W/o providing the (native) mouse event no consumer can react accordingly.
With this change the mouse event is emitted as first argument in the click event.
coreui-vue/packages/coreui-vue/src/components/link/CLink.ts
Lines 44 to 46 in a5c0ad5