From 6ecd5de865b3d1bb824a8a5eb3b314f04dda7f55 Mon Sep 17 00:00:00 2001 From: Farhan Khan Date: Sat, 23 Sep 2017 22:18:19 -0400 Subject: [PATCH] m4/host-os.m4: Fixed bug inserting string 'GNU/' to Linux, kFreeBSD, etc Operating systems consist of far more than their core utilities. If its argued that we should acknowledge the userspace, we should be consistent and acknowledge all of the userspace. Change the string to 'BSD/Oracle/Microsoft/Redhat/ISC/Apache/MIT/GNU/Linux'. This would quickly grow unwieldly and ridiculous, and thus should be avoided. Additionally, installing a single GNU utility such as 'uname' on a FreeBSD machine, does not make the system GNU/FreeBSD. Sane alternatives to this bug fix may be: * Or replace the 'o' flag with an attempt to determine the actual OS. (ie, Fedora, Ubuntu, Arch, etc.) from standard version files. * Update uname(3) and 'struct utsname' to include OS version information. * Just call it Linux. --- m4/host-os.m4 | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/m4/host-os.m4 b/m4/host-os.m4 index 0f1a1040df..a989f6be6d 100644 --- a/m4/host-os.m4 +++ b/m4/host-os.m4 @@ -38,17 +38,17 @@ AC_DEFUN([gl_HOST_OS], openbsd*) os='OpenBSD';; nsk*) os='NonStop Kernel';; nonstopux*) os='NonStop-UX';; - netbsd*-gnu*) os='GNU/NetBSD';; # NetBSD kernel+libc, GNU userland + netbsd*-gnu*) os='NetBSD';; # NetBSD kernel+libc, diverse userland netbsd*) os='NetBSD';; mirbsd*) os='MirBSD';; - knetbsd*-gnu) os='GNU/kNetBSD';; # NetBSD kernel, GNU libc+userland - kfreebsd*-gnu) os='GNU/kFreeBSD';; # FreeBSD kernel, GNU libc+userland + knetbsd*-gnu) os='kNetBSD';; # NetBSD kernel, diverse libc+userland + kfreebsd*-gnu) os='kFreeBSD';; # FreeBSD kernel, diverse libc+userland msdosdjgpp*) os='DJGPP';; mpeix*) os='MPE/iX';; mint*) os='MiNT';; mingw*) os='MinGW';; lynxos*) os='LynxOS';; - linux*) os='GNU/Linux';; + linux*) os='Linux';; hpux*) os='HP-UX';; hiux*) os='HI-UX';; gnu*) os='GNU';;