From 357748e8e8a21894138cae2c8252be2250d8b871 Mon Sep 17 00:00:00 2001 From: Chris C Date: Tue, 8 Feb 2022 15:04:15 -0700 Subject: [PATCH 01/22] First test of using composite action. --- .../workflows/calculate-version-action.yml | 32 +++++++++++ .github/workflows/ci.yml | 54 ++++++++++--------- 2 files changed, 61 insertions(+), 25 deletions(-) create mode 100644 .github/workflows/calculate-version-action.yml diff --git a/.github/workflows/calculate-version-action.yml b/.github/workflows/calculate-version-action.yml new file mode 100644 index 0000000..264aefe --- /dev/null +++ b/.github/workflows/calculate-version-action.yml @@ -0,0 +1,32 @@ +name: 'Calculate Version Action' +description: 'Calculate the next version number using GitVersion.' + +outputs: + version_formats: + description: 'The various formats for the version. See GitVersion for more details.' + value: ${{ steps.random-number-generator.outputs }} + +runs: + using: "composite" + steps: + - name: Install .NET Core 6 + uses: actions/setup-dotnet@v1 + with: + dotnet-version: '6.0.x' + + - name: Install GitVersion + uses: gittools/actions/gitversion/setup@v0.9.11 + with: + versionSpec: '5.8.1' + + - name: GitVersion Config + uses: gittools/actions/gitversion/execute@v0.9.11 + with: + useConfigFile: true + additionalArguments: '/showConfig' + + - name: Determine Version + uses: gittools/actions/gitversion/execute@v0.9.11 + id: gitversion + with: + useConfigFile: true \ No newline at end of file diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml index 673c12f..708a186 100644 --- a/.github/workflows/ci.yml +++ b/.github/workflows/ci.yml @@ -84,41 +84,45 @@ jobs: with: fetch-depth: 0 # Required for GitVersion - - name: Install .NET Core 6 - uses: actions/setup-dotnet@v1 - with: - dotnet-version: '6.0.x' - - - name: Install GitVersion - uses: gittools/actions/gitversion/setup@v0.9.11 - with: - versionSpec: '5.8.1' - - - name: GitVersion Config - uses: gittools/actions/gitversion/execute@v0.9.11 - with: - useConfigFile: true - additionalArguments: '/showConfig' - - - name: Determine Version - uses: gittools/actions/gitversion/execute@v0.9.11 - id: gitversion - with: - useConfigFile: true + - name: Calculate Version + id: calculate_version + uses: .github/actions/calculate-version-action.yml + + # - name: Install .NET Core 6 + # uses: actions/setup-dotnet@v1 + # with: + # dotnet-version: '6.0.x' + + # - name: Install GitVersion + # uses: gittools/actions/gitversion/setup@v0.9.11 + # with: + # versionSpec: '5.8.1' + + # - name: GitVersion Config + # uses: gittools/actions/gitversion/execute@v0.9.11 + # with: + # useConfigFile: true + # additionalArguments: '/showConfig' + + # - name: Determine Version + # uses: gittools/actions/gitversion/execute@v0.9.11 + # id: gitversion + # with: + # useConfigFile: true - name: Update the Version run: | - sed -i 's/.*IDE_VERSION=.*/IDE_VERSION="${{ steps.gitversion.outputs.semver }}"/' lib/ruby-debug-ide/version.rb + sed -i 's/.*IDE_VERSION=.*/IDE_VERSION="${{ steps.calculate_version.outputs.semver }}"/' lib/ruby-debug-ide/version.rb cat lib/ruby-debug-ide/version.rb - name: Create Gem run: | - gem build ruby-debug-ide.gemspec -o corigbytes-ruby-debug-ide-${{ steps.gitversion.outputs.semver }}.gem + gem build ruby-debug-ide.gemspec -o corigbytes-ruby-debug-ide-${{ steps.calculate_version.outputs.semver }}.gem - name: Upload GitHub Workflow Artifacts uses: actions/upload-artifact@v2 with: - name: corigbytes-ruby-debug-ide-${{ steps.gitversion.outputs.semver }}.gem - path: corigbytes-ruby-debug-ide-${{ steps.gitversion.outputs.semver }}.gem + name: corigbytes-ruby-debug-ide-${{ steps.calculate_version.outputs.semver }}.gem + path: corigbytes-ruby-debug-ide-${{ steps.calculate_version.outputs.semver }}.gem \ No newline at end of file From f680e316d6047b087caac4207fd0f9502b099905 Mon Sep 17 00:00:00 2001 From: Chris C Date: Tue, 8 Feb 2022 15:06:23 -0700 Subject: [PATCH 02/22] Fix path issue with CI calling composite action. --- .github/workflows/ci.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml index 708a186..a973576 100644 --- a/.github/workflows/ci.yml +++ b/.github/workflows/ci.yml @@ -86,7 +86,7 @@ jobs: - name: Calculate Version id: calculate_version - uses: .github/actions/calculate-version-action.yml + uses: ./.github/actions/calculate-version-action.yml # - name: Install .NET Core 6 # uses: actions/setup-dotnet@v1 From f501cbeff709cc1eeab5eb124216d258c1723197 Mon Sep 17 00:00:00 2001 From: Chris C Date: Tue, 8 Feb 2022 15:13:23 -0700 Subject: [PATCH 03/22] Try to fix composite action path. --- .../calculate-version.yml} | 2 +- .github/workflows/ci.yml | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) rename .github/{workflows/calculate-version-action.yml => actions/calculate-version.yml} (96%) diff --git a/.github/workflows/calculate-version-action.yml b/.github/actions/calculate-version.yml similarity index 96% rename from .github/workflows/calculate-version-action.yml rename to .github/actions/calculate-version.yml index 264aefe..c5bd2fd 100644 --- a/.github/workflows/calculate-version-action.yml +++ b/.github/actions/calculate-version.yml @@ -1,4 +1,4 @@ -name: 'Calculate Version Action' +name: 'Calculate Version' description: 'Calculate the next version number using GitVersion.' outputs: diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml index a973576..606dc35 100644 --- a/.github/workflows/ci.yml +++ b/.github/workflows/ci.yml @@ -86,7 +86,7 @@ jobs: - name: Calculate Version id: calculate_version - uses: ./.github/actions/calculate-version-action.yml + uses: ./.github/actions/calculate-version # - name: Install .NET Core 6 # uses: actions/setup-dotnet@v1 From c172c480d88b9d29a47fc78d110f82a53d7d25eb Mon Sep 17 00:00:00 2001 From: Chris C Date: Tue, 8 Feb 2022 15:16:14 -0700 Subject: [PATCH 04/22] Try again to fix composite action path. --- .../{calculate-version.yml => calculate-version/action.yml} | 0 1 file changed, 0 insertions(+), 0 deletions(-) rename .github/actions/{calculate-version.yml => calculate-version/action.yml} (100%) diff --git a/.github/actions/calculate-version.yml b/.github/actions/calculate-version/action.yml similarity index 100% rename from .github/actions/calculate-version.yml rename to .github/actions/calculate-version/action.yml From 1b01fea00978c9536089b8e0dd02f5c28a458476 Mon Sep 17 00:00:00 2001 From: Chris C Date: Thu, 10 Feb 2022 16:31:11 -0700 Subject: [PATCH 05/22] Added the release generation workflow. --- .github/actions/calculate-version/action.yml | 10 ++++ .github/workflows/ci.yml | 24 +--------- .github/workflows/release-notes.yml | 50 ++++++++++++++++++++ 3 files changed, 61 insertions(+), 23 deletions(-) create mode 100644 .github/workflows/release-notes.yml diff --git a/.github/actions/calculate-version/action.yml b/.github/actions/calculate-version/action.yml index c5bd2fd..5fab64a 100644 --- a/.github/actions/calculate-version/action.yml +++ b/.github/actions/calculate-version/action.yml @@ -1,3 +1,13 @@ +# Calculates the next version number. Assumes +# that the code has already been checked out and that +# the fetch-depth is zero: +# +# uses: actions/checkout@v2 +# with: +# fetch-depth: 0 +# +# More details: https://gitversion.net/docs/reference/requirements + name: 'Calculate Version' description: 'Calculate the next version number using GitVersion.' diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml index 606dc35..fec2735 100644 --- a/.github/workflows/ci.yml +++ b/.github/workflows/ci.yml @@ -82,34 +82,12 @@ jobs: - name: Checkout uses: actions/checkout@v2 with: - fetch-depth: 0 # Required for GitVersion + fetch-depth: 0 # Required for Calculate Version step (e.g. GitVersion) - name: Calculate Version id: calculate_version uses: ./.github/actions/calculate-version - # - name: Install .NET Core 6 - # uses: actions/setup-dotnet@v1 - # with: - # dotnet-version: '6.0.x' - - # - name: Install GitVersion - # uses: gittools/actions/gitversion/setup@v0.9.11 - # with: - # versionSpec: '5.8.1' - - # - name: GitVersion Config - # uses: gittools/actions/gitversion/execute@v0.9.11 - # with: - # useConfigFile: true - # additionalArguments: '/showConfig' - - # - name: Determine Version - # uses: gittools/actions/gitversion/execute@v0.9.11 - # id: gitversion - # with: - # useConfigFile: true - - name: Update the Version run: | sed -i 's/.*IDE_VERSION=.*/IDE_VERSION="${{ steps.calculate_version.outputs.semver }}"/' lib/ruby-debug-ide/version.rb diff --git a/.github/workflows/release-notes.yml b/.github/workflows/release-notes.yml new file mode 100644 index 0000000..8f47549 --- /dev/null +++ b/.github/workflows/release-notes.yml @@ -0,0 +1,50 @@ +name: Release Notes +on: + push: + branches: [ master, release* ] + pull_request: + branches: [ master, release* ] + +defaults: + run: + shell: bash + +jobs: + generate-release-notes: + name: Generate Release Notes + runs-on: ubuntu-20.04 + + steps: + - name: Checkout + uses: actions/checkout@v2 + with: + fetch-depth: 0 # Required for Calculate Version step (e.g. GitVersion) + + - name: Calculate Version + id: calculate_version + uses: ./.github/actions/calculate-version + + - name: Install GitReleaseManager + uses: gittools/actions/gitreleasemanager/setup@v0.9.11 + with: + versionSpec: '0.13.0' + + - name: Create Release + uses: gittools/actions/gitreleasemanager/create@v0.9.11 + with: + token: ${{ secrets.GITHUB_TOKEN }} + owner: 'corgibytes' + repository: 'ruby-debug-ide' + milestone: 'v${{ steps.gitversion.outputs.majorMinorPatch }}' + + - name: 'Generate Change Log' + run: | + dotnet-gitreleasemanager export --token ${{ secrets.GITHUB_TOKEN }} -o 'corgibytes' -r 'ruby-debug-ide' -f 'CHANGELOG.md' + git add --renormalize CHANGELOG.md + cat CHANGELOG.md + + - name: 'Commit Change Log if it Changed' + uses: stefanzweifel/git-auto-commit-action@v4 + with: + commit_message: Committing auto generated change log. + file_pattern: CHANGELOG.md \ No newline at end of file From ceb918094400e0486e03b67a2bffa144bb2fbd45 Mon Sep 17 00:00:00 2001 From: Chris C Date: Tue, 13 Sep 2022 16:21:38 -0600 Subject: [PATCH 06/22] Update action versions in GitVersion CI script. --- .github/actions/calculate-version/action.yml | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/.github/actions/calculate-version/action.yml b/.github/actions/calculate-version/action.yml index 5fab64a..ffe09e8 100644 --- a/.github/actions/calculate-version/action.yml +++ b/.github/actions/calculate-version/action.yml @@ -25,18 +25,18 @@ runs: dotnet-version: '6.0.x' - name: Install GitVersion - uses: gittools/actions/gitversion/setup@v0.9.11 + uses: gittools/actions/gitversion/setup@v0.9.13 with: - versionSpec: '5.8.1' + versionSpec: '5.10.3' - name: GitVersion Config - uses: gittools/actions/gitversion/execute@v0.9.11 + uses: gittools/actions/gitversion/execute@v0.9.13 with: useConfigFile: true additionalArguments: '/showConfig' - name: Determine Version - uses: gittools/actions/gitversion/execute@v0.9.11 + uses: gittools/actions/gitversion/execute@v0.9.13 id: gitversion with: useConfigFile: true \ No newline at end of file From a9d57c0281e93deb1f7dcfd2dc2a70a73839214f Mon Sep 17 00:00:00 2001 From: Chris C Date: Tue, 13 Sep 2022 16:31:26 -0600 Subject: [PATCH 07/22] Fixed some linting errors. Curious if all the linting error fixes are valid for older versions of Ruby. The CI will tell us. --- lib/ruby-debug-ide.rb | 4 ---- lib/ruby-debug-ide/attach/gdb.rb | 5 ----- lib/ruby-debug-ide/attach/lldb.rb | 5 ----- ruby-debug-ide.gemspec | 1 - 4 files changed, 15 deletions(-) diff --git a/lib/ruby-debug-ide.rb b/lib/ruby-debug-ide.rb index 5828df9..24f68ed 100644 --- a/lib/ruby-debug-ide.rb +++ b/lib/ruby-debug-ide.rb @@ -27,7 +27,6 @@ def find_free_port(host) # Loop over each port until we find an open port. possible_port_numbers.each do |ppn| - # rubocop: disable Style/RedundantBegin begin print_debug("Checking if port is free: #{ppn}\n") @@ -43,7 +42,6 @@ def find_free_port(host) # another port. print_debug("Port #{ppn} is in use.\n") end - # rubocop: enable Style/RedundantBegin end # Tried all the ports and couldn't find a free one. @@ -164,7 +162,6 @@ def _start_control_common(host, port, socket_path, notify_dispatcher) return if @control_thread @control_thread = DebugThread.new do - # rubocop: disable Style/RedundantBegin begin if socket_path.nil? # 127.0.0.1 seemingly works with all systems and with IPv6 as well. @@ -213,7 +210,6 @@ def _start_control_common(host, port, socket_path, notify_dispatcher) $stderr.printf "Fatal exception in DebugThread loop: #{$!.message}\nBacktrace:\n#{bt ? bt.join("\n from: ") : ""}\n" exit 2 end - # rubocop: enable Style/RedundantBegin end end diff --git a/lib/ruby-debug-ide/attach/gdb.rb b/lib/ruby-debug-ide/attach/gdb.rb index bf9085c..47295cd 100644 --- a/lib/ruby-debug-ide/attach/gdb.rb +++ b/lib/ruby-debug-ide/attach/gdb.rb @@ -1,11 +1,6 @@ require 'ruby-debug-ide/attach/native_debugger' class GDB < NativeDebugger - - def initialize(executable, pid, flags, gems_to_include, debugger_loader_path, argv) - super(executable, pid, flags, gems_to_include, debugger_loader_path, argv) - end - def set_flags execute 'set scheduler-locking off' # we will deadlock with it execute 'set unwindonsignal on' # in case of some signal we will exit gdb diff --git a/lib/ruby-debug-ide/attach/lldb.rb b/lib/ruby-debug-ide/attach/lldb.rb index b9bdc31..13bb46f 100644 --- a/lib/ruby-debug-ide/attach/lldb.rb +++ b/lib/ruby-debug-ide/attach/lldb.rb @@ -1,11 +1,6 @@ require 'ruby-debug-ide/attach/native_debugger' class LLDB < NativeDebugger - - def initialize(executable, pid, flags, gems_to_include, debugger_loader_path, argv) - super(executable, pid, flags, gems_to_include, debugger_loader_path, argv) - end - def set_flags end diff --git a/ruby-debug-ide.gemspec b/ruby-debug-ide.gemspec index 5b83159..8ed89d6 100644 --- a/ruby-debug-ide.gemspec +++ b/ruby-debug-ide.gemspec @@ -55,5 +55,4 @@ EOF end spec.required_ruby_version = '>= 1.8.2' - spec.date = DateTime.now end From 787e6e87d5853a7c72da288c46a865153a0b0c34 Mon Sep 17 00:00:00 2001 From: Chris C Date: Tue, 13 Sep 2022 16:40:25 -0600 Subject: [PATCH 08/22] Fixed issue with CI release notes not finding version number. --- .github/workflows/release-notes.yml | 15 +++++++-------- 1 file changed, 7 insertions(+), 8 deletions(-) diff --git a/.github/workflows/release-notes.yml b/.github/workflows/release-notes.yml index 8f47549..02485c0 100644 --- a/.github/workflows/release-notes.yml +++ b/.github/workflows/release-notes.yml @@ -25,17 +25,16 @@ jobs: uses: ./.github/actions/calculate-version - name: Install GitReleaseManager - uses: gittools/actions/gitreleasemanager/setup@v0.9.11 + uses: gittools/actions/gitreleasemanager/setup@v0.9.13 with: versionSpec: '0.13.0' - - name: Create Release - uses: gittools/actions/gitreleasemanager/create@v0.9.11 - with: - token: ${{ secrets.GITHUB_TOKEN }} - owner: 'corgibytes' - repository: 'ruby-debug-ide' - milestone: 'v${{ steps.gitversion.outputs.majorMinorPatch }}' + # If there are no closed issues generating the Github Release will fail because it raises an exception. + # Work around this by checking for success or no closed issue errors. + - name: Create Release ${{ env.MajorMinorPatch }} + run: | + dotnet gitreleasemanager create --owner trust-consulting-group --repository trust_v1 --token ${{ secrets.GITHUB_TOKEN }} --milestone v${{ env.GitVersion_MajorMinorPatch }} --logFilePath output.txt || true + cat output.txt | grep 'No closed issues have been found for milestone\|Drafted release is available at' - name: 'Generate Change Log' run: | From 9f62ce0603c70a5cb09b5f54fb7064760a53a929 Mon Sep 17 00:00:00 2001 From: Chris C Date: Tue, 13 Sep 2022 16:45:38 -0600 Subject: [PATCH 09/22] Fix typo in release notes CI and only update build version number. --- .github/workflows/release-notes.yml | 2 +- GitVersion.yml | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/.github/workflows/release-notes.yml b/.github/workflows/release-notes.yml index 02485c0..fb9dfe6 100644 --- a/.github/workflows/release-notes.yml +++ b/.github/workflows/release-notes.yml @@ -33,7 +33,7 @@ jobs: # Work around this by checking for success or no closed issue errors. - name: Create Release ${{ env.MajorMinorPatch }} run: | - dotnet gitreleasemanager create --owner trust-consulting-group --repository trust_v1 --token ${{ secrets.GITHUB_TOKEN }} --milestone v${{ env.GitVersion_MajorMinorPatch }} --logFilePath output.txt || true + dotnet gitreleasemanager create --owner corgibytes --repository ruby-debug-ide --token ${{ secrets.GITHUB_TOKEN }} --milestone v${{ env.GitVersion_MajorMinorPatch }} --logFilePath output.txt || true cat output.txt | grep 'No closed issues have been found for milestone\|Drafted release is available at' - name: 'Generate Change Log' diff --git a/GitVersion.yml b/GitVersion.yml index 62858ac..07249b5 100644 --- a/GitVersion.yml +++ b/GitVersion.yml @@ -2,7 +2,7 @@ branches: main: mode: ContinuousDeployment tag: alpha - increment: Minor + increment: Build prevent-increment-of-merged-branch-version: false track-merge-target: true release: From 2728105a5bd9c0cf8f2126d899e0464451966bd1 Mon Sep 17 00:00:00 2001 From: Chris C Date: Tue, 13 Sep 2022 16:52:31 -0600 Subject: [PATCH 10/22] Don't increment the version for release builds in CI. --- GitVersion.yml | 79 ++++++++++++++++++++++++++++++++++++++++++++++---- 1 file changed, 74 insertions(+), 5 deletions(-) diff --git a/GitVersion.yml b/GitVersion.yml index 07249b5..a9d03f5 100644 --- a/GitVersion.yml +++ b/GitVersion.yml @@ -1,15 +1,84 @@ +next-version: 1.0 +assembly-versioning-scheme: MajorMinorPatch +assembly-file-versioning-scheme: MajorMinorPatch +assembly-informational-format: '{InformationalVersion}' +mode: ContinuousDelivery +increment: Inherit +continuous-delivery-fallback-tag: ci +tag-prefix: '[vV]' +major-version-bump-message: '\+semver:\s?(breaking|major)' +minor-version-bump-message: '\+semver:\s?(feature|minor)' +patch-version-bump-message: '\+semver:\s?(fix|patch)' +no-bump-message: '\+semver:\s?(none|skip)' +legacy-semver-padding: 4 +build-metadata-padding: 4 +commits-since-version-source-padding: 4 +tag-pre-release-weight: 60000 +commit-message-incrementing: Enabled +ignore: + sha: [ ] +merge-message-formats: {} +update-build-number: true + branches: main: + regex: ^master$|^main$ mode: ContinuousDeployment tag: alpha - increment: Build + increment: Patch prevent-increment-of-merged-branch-version: false track-merge-target: true + source-branches: [ ] + tracks-release-branches: true + is-release-branch: false + is-mainline: false + pre-release-weight: 0 release: + regex: ^releases?[/-] + mode: ContinuousDeployment tag: beta - increment: Patch + increment: None prevent-increment-of-merged-branch-version: true track-merge-target: false -ignore: - sha: [] -merge-message-formats: {} \ No newline at end of file + source-branches: [ 'main' ] + tracks-release-branches: false + is-release-branch: true + is-mainline: false + pre-release-weight: 30000 + feature: + regex: ^features?[/-] + mode: ContinuousDelivery + tag: useBranchName + increment: Inherit + prevent-increment-of-merged-branch-version: false + track-merge-target: false + source-branches: [ 'main', 'release' ] + tracks-release-branches: false + is-release-branch: false + is-mainline: false + pre-release-weight: 30000 + pull-request: + regex: ^(pull|pull\-requests|pr)[/-] + mode: ContinuousDelivery + tag: PullRequest + increment: Inherit + prevent-increment-of-merged-branch-version: false + tag-number-pattern: '[/-](?\d+)[-/]' + track-merge-target: false + source-branches: [ 'main', 'release', 'hotfix' ] + tracks-release-branches: false + is-release-branch: false + is-mainline: false + pre-release-weight: 30000 + hotfix: + regex: ^hotfix(es)?[/-] + mode: ContinuousDelivery + tag: useBranchName + increment: Inherit + prevent-increment-of-merged-branch-version: false + track-merge-target: false + source-branches: [ 'release' ] + tracks-release-branches: false + is-release-branch: false + is-mainline: false + pre-release-weight: 30000 \ No newline at end of file From 48b18ec47cde4c4c97dffb77cbf3315395ba5976 Mon Sep 17 00:00:00 2001 From: Chris C Date: Tue, 13 Sep 2022 16:54:10 -0600 Subject: [PATCH 11/22] Remove next version is GitVersion config file. --- GitVersion.yml | 1 - 1 file changed, 1 deletion(-) diff --git a/GitVersion.yml b/GitVersion.yml index a9d03f5..17c7ef8 100644 --- a/GitVersion.yml +++ b/GitVersion.yml @@ -1,4 +1,3 @@ -next-version: 1.0 assembly-versioning-scheme: MajorMinorPatch assembly-file-versioning-scheme: MajorMinorPatch assembly-informational-format: '{InformationalVersion}' From c3a23c7151d46deafa8224bc7fadced00063dcb5 Mon Sep 17 00:00:00 2001 From: Chris C Date: Tue, 13 Sep 2022 16:56:45 -0600 Subject: [PATCH 12/22] Added GitReleaseManger config for labels. --- GitReleaseManger.yml | 32 ++++++++++++++++++++++++++++++++ 1 file changed, 32 insertions(+) create mode 100644 GitReleaseManger.yml diff --git a/GitReleaseManger.yml b/GitReleaseManger.yml new file mode 100644 index 0000000..86804ee --- /dev/null +++ b/GitReleaseManger.yml @@ -0,0 +1,32 @@ +issue-labels-include: + - bug + - devops + - dependencies + - documentation + - enhancement + - security + +issue-labels-alias: + - name: bug + header: Bug + plural: Bugs + + - name: dependencies + header: Dependencies + plural: Dependencies + + - name: devops + header: DevOps + plural: DevOps + + - name: documentation + header: Documentation + plural: Documentation + + - name: enhancement + header: Enhancement + plural: Enhancements + + - name: security + header: Security + plural: Security \ No newline at end of file From a1bb76eafc062e0ccb81394873e6d4266e490bc5 Mon Sep 17 00:00:00 2001 From: Chris C Date: Tue, 13 Sep 2022 17:01:29 -0600 Subject: [PATCH 13/22] Fix typo in Git Release Manager config file name. --- GitReleaseManger.yml => GitReleaseManager.yml | 0 1 file changed, 0 insertions(+), 0 deletions(-) rename GitReleaseManger.yml => GitReleaseManager.yml (100%) diff --git a/GitReleaseManger.yml b/GitReleaseManager.yml similarity index 100% rename from GitReleaseManger.yml rename to GitReleaseManager.yml From f66187e482540b550f19b7b7bde1f3109371488f Mon Sep 17 00:00:00 2001 From: mrbiggred Date: Tue, 13 Sep 2022 23:02:07 +0000 Subject: [PATCH 14/22] Committing auto generated change log. --- CHANGELOG.md | 22 ++++++++++++++++++++++ 1 file changed, 22 insertions(+) create mode 100644 CHANGELOG.md diff --git a/CHANGELOG.md b/CHANGELOG.md new file mode 100644 index 0000000..85e3337 --- /dev/null +++ b/CHANGELOG.md @@ -0,0 +1,22 @@ +## v0.7.100 + + +As part of this release we had [9 issues](https://github.com/corgibytes/ruby-debug-ide/milestone/1?closed=1) closed. + + + +__DevOps__ + +- [__#8__](https://github.com/corgibytes/ruby-debug-ide/pull/8) Create Gemfile package in CI + +__Enhancements__ + +- [__#1__](https://github.com/corgibytes/ruby-debug-ide/pull/1) Docker container for development +- [__#2__](https://github.com/corgibytes/ruby-debug-ide/pull/2) Create GitHub CI +- [__#3__](https://github.com/corgibytes/ruby-debug-ide/pull/3) Get latest changes from Ruby Debug IDE origin +- [__#4__](https://github.com/corgibytes/ruby-debug-ide/pull/4) Trigger CI on PR +- [__#5__](https://github.com/corgibytes/ruby-debug-ide/pull/5) Trigger CI on push and PR +- [__#6__](https://github.com/corgibytes/ruby-debug-ide/pull/6) Add fixed port range +- [__#7__](https://github.com/corgibytes/ruby-debug-ide/pull/7) Add Standard lint checker +- [__#9__](https://github.com/corgibytes/ruby-debug-ide/pull/9) Fixed some new linting errors with new version of Rubocop + From b2d2f16276c4261a813c2842000f016f59d6f50d Mon Sep 17 00:00:00 2001 From: Chris C Date: Tue, 13 Sep 2022 17:33:37 -0600 Subject: [PATCH 15/22] Trying the Rubocop TargetRubyVersion. --- .standard.yml | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/.standard.yml b/.standard.yml index 816447a..1421f3c 100644 --- a/.standard.yml +++ b/.standard.yml @@ -6,4 +6,7 @@ ruby_version: 1.9.3 ignore: - '**/*': - Style/SafeNavigation # The & nil check is not available until Ruby 2.3. - - Lint/IncompatibleIoSelectWithFiberScheduler # Couldn't get this recommened fix to work in the interface.rb non_blocking_gets method. \ No newline at end of file + - Lint/IncompatibleIoSelectWithFiberScheduler # Couldn't get this recommend fix to work in the interface.rb non_blocking_gets method. + +AllCops: + TargetRubyVersion: 1.9.3 \ No newline at end of file From 0b640d2f2c39c350ea4f129b64aec8425716116a Mon Sep 17 00:00:00 2001 From: Chris C Date: Thu, 15 Sep 2022 10:11:40 -0600 Subject: [PATCH 16/22] Testing changes to the Standard linter. --- .standard.yml | 7 ++----- Dockerfile | 6 +++--- Gemfile | 2 +- 3 files changed, 6 insertions(+), 9 deletions(-) diff --git a/.standard.yml b/.standard.yml index 1421f3c..6c89173 100644 --- a/.standard.yml +++ b/.standard.yml @@ -1,12 +1,9 @@ # Oldest version of Ruby supported by the Debugger. -ruby_version: 1.9.3 +ruby_version: 1.9 # Ignore some rules that are only valid in # newer versions of Ruby. ignore: - '**/*': - Style/SafeNavigation # The & nil check is not available until Ruby 2.3. - - Lint/IncompatibleIoSelectWithFiberScheduler # Couldn't get this recommend fix to work in the interface.rb non_blocking_gets method. - -AllCops: - TargetRubyVersion: 1.9.3 \ No newline at end of file + - Lint/IncompatibleIoSelectWithFiberScheduler # Couldn't get this recommend fix to work in the interface.rb non_blocking_gets method. \ No newline at end of file diff --git a/Dockerfile b/Dockerfile index 8d1cdf7..ca7299c 100644 --- a/Dockerfile +++ b/Dockerfile @@ -1,15 +1,15 @@ FROM ruby:2.6.6-slim # Install build tooks. -RUN apt update && apt install -y build-essential +RUN apt update && apt install -y build-essential git # Working folder. RUN mkdir /app WORKDIR /app # Setup bundler. -RUN gem update --system 3.1.4 && \ - gem install bundler -v 2.1.4 +RUN gem update --system 3.3.22 && \ + gem install bundler -v 2.3.22 # Entrypoint script will install gems. COPY docker-entrypoint.sh docker-entrypoint.sh diff --git a/Gemfile b/Gemfile index 0af7d30..d6620ba 100644 --- a/Gemfile +++ b/Gemfile @@ -37,6 +37,6 @@ group :development, :test do # versions of Standard might not support all the features # such as the to-do file. if RUBY_VERSION >= "2.2.0" - gem "standard" + gem "standard", git: "https://github.com/corgibytes/standard", ref: "8f06bf4ae25411e4e63d5d156dda1295c9b49405" end end From 6afd9074bb2b6af1fe6820a7b1a072a5a857264f Mon Sep 17 00:00:00 2001 From: Chris C Date: Thu, 15 Sep 2022 10:17:41 -0600 Subject: [PATCH 17/22] Testing with Standard that has less Ruby requirements. --- Gemfile | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/Gemfile b/Gemfile index d6620ba..e83635a 100644 --- a/Gemfile +++ b/Gemfile @@ -37,6 +37,6 @@ group :development, :test do # versions of Standard might not support all the features # such as the to-do file. if RUBY_VERSION >= "2.2.0" - gem "standard", git: "https://github.com/corgibytes/standard", ref: "8f06bf4ae25411e4e63d5d156dda1295c9b49405" + gem "standard", git: "https://github.com/corgibytes/standard", ref: "59790b6d05e08a23249a1c70a30aa9ba1b67b33f" end end From b75c31ff8172b1712876d55e3c910c952492dbf1 Mon Sep 17 00:00:00 2001 From: Chris C Date: Thu, 15 Sep 2022 10:22:07 -0600 Subject: [PATCH 18/22] Testing Standard with less restrictive Rubocop version. --- Gemfile | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/Gemfile b/Gemfile index e83635a..4f52620 100644 --- a/Gemfile +++ b/Gemfile @@ -37,6 +37,6 @@ group :development, :test do # versions of Standard might not support all the features # such as the to-do file. if RUBY_VERSION >= "2.2.0" - gem "standard", git: "https://github.com/corgibytes/standard", ref: "59790b6d05e08a23249a1c70a30aa9ba1b67b33f" + gem "standard", git: "https://github.com/corgibytes/standard", ref: "8a5a774f01fa4d705cc11d3cba7db7a7552cec0c" end end From 0a15dd085a0f55ee0dae4d48dbcdc176b9260f48 Mon Sep 17 00:00:00 2001 From: Chris C Date: Thu, 15 Sep 2022 11:00:46 -0600 Subject: [PATCH 19/22] Another test of the Standard gem changes. --- Gemfile | 8 +++----- 1 file changed, 3 insertions(+), 5 deletions(-) diff --git a/Gemfile b/Gemfile index 4f52620..0f9893d 100644 --- a/Gemfile +++ b/Gemfile @@ -33,10 +33,8 @@ group :development, :test do gem "test-unit" end - # Minimum Ruby version for Standard. That said the old - # versions of Standard might not support all the features - # such as the to-do file. - if RUBY_VERSION >= "2.2.0" - gem "standard", git: "https://github.com/corgibytes/standard", ref: "8a5a774f01fa4d705cc11d3cba7db7a7552cec0c" + # REM + if RUBY_VERSION >= "2.6" + gem "standard", git: "https://github.com/corgibytes/standard", ref: "28fd6199ec21a2a1b9db77f61e29febbd0e0977f" end end From 0859bd1b72e52e8759dd58aa28fe0a59b9faf43a Mon Sep 17 00:00:00 2001 From: Chris C Date: Thu, 15 Sep 2022 11:01:29 -0600 Subject: [PATCH 20/22] Linting not supported on Ruby 2.5 anymore. --- .github/workflows/ci.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml index fec2735..20b09ef 100644 --- a/.github/workflows/ci.yml +++ b/.github/workflows/ci.yml @@ -45,7 +45,7 @@ jobs: - ruby-version: 2.5.8 bundler-version: 2.2.32 - run-linter: true + run-linter: false - ruby-version: 2.6.6 bundler-version: 2.2.32 From b5f36bc47985a5c092a66d922ed2b3b5bbe7c5ab Mon Sep 17 00:00:00 2001 From: Chris C Date: Thu, 15 Sep 2022 12:28:01 -0600 Subject: [PATCH 21/22] See if the Standard updates mean we can remove some ignores. --- .standard.yml | 9 +-------- Gemfile | 2 +- 2 files changed, 2 insertions(+), 9 deletions(-) diff --git a/.standard.yml b/.standard.yml index 6c89173..1701cf0 100644 --- a/.standard.yml +++ b/.standard.yml @@ -1,9 +1,2 @@ # Oldest version of Ruby supported by the Debugger. -ruby_version: 1.9 - -# Ignore some rules that are only valid in -# newer versions of Ruby. -ignore: - - '**/*': - - Style/SafeNavigation # The & nil check is not available until Ruby 2.3. - - Lint/IncompatibleIoSelectWithFiberScheduler # Couldn't get this recommend fix to work in the interface.rb non_blocking_gets method. \ No newline at end of file +ruby_version: 1.9 \ No newline at end of file diff --git a/Gemfile b/Gemfile index 0f9893d..3d2ca89 100644 --- a/Gemfile +++ b/Gemfile @@ -35,6 +35,6 @@ group :development, :test do # REM if RUBY_VERSION >= "2.6" - gem "standard", git: "https://github.com/corgibytes/standard", ref: "28fd6199ec21a2a1b9db77f61e29febbd0e0977f" + gem "standard", git: "https://github.com/corgibytes/standard", ref: "7b5f0bf354ee88697e3f1d54ed1d231670625d4b" end end From d7a8612525222bea2e9f2ea3390f13d1e78c5d98 Mon Sep 17 00:00:00 2001 From: Chris C Date: Thu, 15 Sep 2022 16:09:48 -0600 Subject: [PATCH 22/22] Updated the latest Standard fix. --- Gemfile | 2 +- README.md | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/Gemfile b/Gemfile index 3d2ca89..7cacec1 100644 --- a/Gemfile +++ b/Gemfile @@ -35,6 +35,6 @@ group :development, :test do # REM if RUBY_VERSION >= "2.6" - gem "standard", git: "https://github.com/corgibytes/standard", ref: "7b5f0bf354ee88697e3f1d54ed1d231670625d4b" + gem "standard", git: "https://github.com/corgibytes/standard", ref: "64ddc304a5df706ede8bbbb3b0483cc67ee65a4a" end end diff --git a/README.md b/README.md index b026628..864eb71 100644 --- a/README.md +++ b/README.md @@ -50,7 +50,7 @@ docker-compose build Then run the container: ```bash -docker-compose run app bash +docker-compose run --rm app bash ``` Note: The gems are not installed until the container is run and the [docker-entrypoint.sh](docker-entrypoint.sh) is called.