Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Extra partitions #70

Closed
wants to merge 5 commits into from
Closed

Extra partitions #70

wants to merge 5 commits into from

Conversation

kakaroto
Copy link
Contributor

This basically add a '-e' / --extra-partitions argument to allow selection of extra partitions to keep. This is useful on some machines, such as the Librem 13 v2, which require the MFS partition to be kept intact in order to get the Wifi PCIe module to get initialized.

@kakaroto
Fix lenght->length typo in variable name
fa94786
@kakaroto
Remove invalid and unused header_len variable
184ac81
@kakaroto
Add support for selective partition removal
cb1032f 
Check and remove partitions from $FPT based on their name instead of
removing all partitions different from FTPR and hardcoding the addition
of FTPR partition into $FPT.

This is required in order to add support for unremovable partitions,
other than FTPR, which is required on some machines.
@kakaroto
Add -e option to select extra partitions to keep
a150d27
@kakaroto
Change debug line to avoid confusion with new --extra-partitions argu…
9facf98 
…ment
@corna corna mentioned this pull request Oct 8, 2017
Closed
@corna
Copy link
Owner

corna commented Oct 15, 2017

Thank you Youness. Did you solve the power problems related to the MFS partition?

@corna
Copy link
Owner

corna commented Oct 15, 2017

I've just reviewed the patch, thank you for submitting it.
I've fixed some issues in it (PEP8, non-ASCII partition names, partitions outside the flash) and I've pushed the result in the dev branch. I've also squashed the last 3 commits.

If you're ok with it I can merge it in master.

@kakaroto
Copy link
Contributor Author

Thanks! Yes, I'm ok with the squashing, it makes sense.
I did solve the power related problems, but unexpectedly. It turns out they only happened on one of the prototypes I was testing on, but there are no issues on any other laptops we tested on, and users from forums who tested it also reported no power problems, so I'm assuming it's a hardware issue with one specific prototype only. It is weird that it doesn't happen on the prototype without the neutralized ME, but that's acceptable, I won't look into it any more.

@kakaroto kakaroto closed this Oct 16, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@kakaroto @corna