Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Flag `--namespace` now implies `--only-scope=namespace` #18

Merged
merged 2 commits into from Mar 25, 2019

Conversation

Projects
None yet
2 participants
@corneliusweig
Copy link
Owner

commented Mar 25, 2019

Before, the effect of --namespace was to exclude namespace resources from namespaces other than the given one, because all cluster-scoped resources were still printed. Now, --namespace will only show namespaced resources from the given namespace.

corneliusweig added some commits Mar 25, 2019

Specifying the `--namespace` flag should imply `--only-scope=namespace`
Before, the effect of `--namespace` was to exclude namespace resources from namespaces other than the given one, because all cluster-scoped resources were still printed.
Now, `--namespace` will only show namespaced resources from the given namespace.

@corneliusweig corneliusweig force-pushed the namespace-restricts-scope branch from 65b8339 to 0944390 Mar 25, 2019

@codecov-io

This comment has been minimized.

Copy link

commented Mar 25, 2019

Codecov Report

Merging #18 into master will not change coverage.
The diff coverage is 0%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master      #18   +/-   ##
=======================================
  Coverage   33.56%   33.56%           
=======================================
  Files           6        6           
  Lines         286      286           
=======================================
  Hits           96       96           
  Misses        184      184           
  Partials        6        6
Impacted Files Coverage Δ
pkg/ketall/client/client.go 24.4% <0%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e1d48e9...0944390. Read the comment docs.

@corneliusweig corneliusweig merged commit 631cbd8 into master Mar 25, 2019

2 of 3 checks passed

codecov/patch 0% of diff hit (target 33.56%)
Details
Travis CI - Pull Request Build Passed
Details
codecov/project 33.56% remains the same compared to be87076
Details

@corneliusweig corneliusweig deleted the namespace-restricts-scope branch Mar 25, 2019

corneliusweig added a commit to corneliusweig/krew-index that referenced this pull request Mar 25, 2019

Update plugin "get-all" to v1.1.0
Release notes:

* Flag `--namespace` now implies `--only-scope=namespace`
[kubernetes-sigs#18](corneliusweig/ketall#18)
* Add new flag `--since` to filter resources by creation timestamp
[kubernetes-sigs#17](corneliusweig/ketall#17)
* Fix travis releases
[#15](corneliusweig/ketall#15)

corneliusweig added a commit to corneliusweig/krew-index that referenced this pull request Mar 25, 2019

Update plugin "get-all" to v1.1.0
Release notes:

* Flag `--namespace` now implies `--only-scope=namespace`
[kubernetes-sigs#18](corneliusweig/ketall#18)
* Add new flag `--since` to filter resources by creation timestamp
[kubernetes-sigs#17](corneliusweig/ketall#17)
* Fix travis releases
[#15](corneliusweig/ketall#15)

Signed-off-by: Cornelius Weig <22861411+corneliusweig@users.noreply.github.com>

corneliusweig added a commit to corneliusweig/krew-index that referenced this pull request Mar 25, 2019

Update plugin "get-all" to v1.1.0
Release notes:

* Flag `--namespace` now implies `--only-scope=namespace`
[kubernetes-sigs#18](corneliusweig/ketall#18)
* Add new flag `--since` to filter resources by creation timestamp
[kubernetes-sigs#17](corneliusweig/ketall#17)
* Fix travis releases
[#15](corneliusweig/ketall#15)

Signed-off-by: Cornelius Weig <22861411+corneliusweig@users.noreply.github.com>

@corneliusweig corneliusweig referenced this pull request Mar 25, 2019

Merged

Update plugin "get-all" to v1.1.0 #119

0 of 2 tasks complete

ahmetb added a commit to kubernetes-sigs/krew-index that referenced this pull request Mar 25, 2019

Update plugin "get-all" to v1.1.0 (#119)
Release notes:

* Flag `--namespace` now implies `--only-scope=namespace`
[#18](corneliusweig/ketall#18)
* Add new flag `--since` to filter resources by creation timestamp
[#17](corneliusweig/ketall#17)
* Fix travis releases
[#15](corneliusweig/ketall#15)

Signed-off-by: Cornelius Weig <22861411+corneliusweig@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.