Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix bug with empty filter #19

Merged
merged 1 commit into from Mar 25, 2019

Conversation

Projects
None yet
2 participants
@corneliusweig
Copy link
Owner

commented Mar 25, 2019

This only appeared in production builds.

Fix bug with empty filter
This only appeared in production builds.
@codecov-io

This comment has been minimized.

Copy link

commented Mar 25, 2019

Codecov Report

Merging #19 into master will decrease coverage by 0.34%.
The diff coverage is 0%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #19      +/-   ##
==========================================
- Coverage   33.56%   33.21%   -0.35%     
==========================================
  Files           6        6              
  Lines         286      289       +3     
==========================================
  Hits           96       96              
- Misses        184      187       +3     
  Partials        6        6
Impacted Files Coverage Δ
pkg/ketall/filter/filter.go 61.76% <0%> (-2.86%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0eac113...a06f97f. Read the comment docs.

@corneliusweig corneliusweig merged commit cdc5748 into master Mar 25, 2019

2 of 4 checks passed

codecov/patch 0% of diff hit (target 33.56%)
Details
codecov/project 33.21% (-0.35%) compared to 0944390
Details
Travis CI - Branch Build Passed
Details
Travis CI - Pull Request Build Passed
Details

@corneliusweig corneliusweig deleted the fix-empty-filter branch Mar 25, 2019

corneliusweig added a commit to corneliusweig/krew-index that referenced this pull request Mar 25, 2019

Update plugin "get-all" to v1.1.1
* Fix bug with empty filter [kubernetes-sigs#19](corneliusweig/ketall#19)

Signed-off-by: Cornelius Weig <22861411+corneliusweig@users.noreply.github.com>

@corneliusweig corneliusweig referenced this pull request Mar 25, 2019

Merged

Update plugin "get-all" to v1.1.1 #120

0 of 2 tasks complete

ahmetb added a commit to kubernetes-sigs/krew-index that referenced this pull request Mar 25, 2019

Update plugin "get-all" to v1.1.1 (#120)
* Fix bug with empty filter [#19](corneliusweig/ketall#19)

Signed-off-by: Cornelius Weig <22861411+corneliusweig@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.