Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Walkthrough #120

Merged
merged 15 commits into from Oct 4, 2020
Merged

Walkthrough #120

merged 15 commits into from Oct 4, 2020

Conversation

rmz38
Copy link
Contributor

@rmz38 rmz38 commented May 7, 2020

Summary

This pull request is for the new walk through designed by Chris. It uses IntroJs to implement the tour. So far, it implements Chris' walk through that procs after onboarding is finished. If the dashboard initializes with a semester, this will work as intended. However, it does not, so the walk through stops at the requirements bar.

  • implemented the initial walk through assuming one semester exists
  • figured out creating walk throughs when first using a feature using firebase
  • styled tooltips
  • implemented the walk through when first using a feature
  • found a workaround for the issue of no semesters existing

Test Plan

I used the site before and after onboarding to test:
image
image
image

@rmz38 rmz38 requested a review from a team as a code owner May 7, 2020 02:36
@dti-github-bot
Copy link
Member

dti-github-bot commented May 7, 2020

[diff-counting] Significant lines: 415.

@dti-github-bot
Copy link
Member

[deployment-bot] Deployed to https://cornell-dti.github.io/course-plan/120/index.html

@willespencer willespencer self-requested a review May 7, 2020 03:39
Copy link
Member

@willespencer willespencer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking pretty good so far! Left a couple comments about the code. Also ran into a couple bugs when testing! And I'll test again once we figure out the initial semester issue.

  • Pressing the skip button doesn't actually skip the walkthrough.
  • The walkthrough is activated when your profile is edited, not just the first time you log in

I am really excited for this though, it looks so good 😄

src/assets/scss/introjs.scss Show resolved Hide resolved
src/assets/scss/introjs.scss Outdated Show resolved Hide resolved
src/assets/scss/introjs.scss Outdated Show resolved Hide resolved
src/assets/scss/introjs.scss Outdated Show resolved Hide resolved
src/assets/scss/introjs.scss Outdated Show resolved Hide resolved
src/components/Modals/TourWindow.vue Outdated Show resolved Hide resolved
src/components/Modals/TourWindow.vue Outdated Show resolved Hide resolved
src/components/Requirements.vue Outdated Show resolved Hide resolved
src/components/Semester.vue Outdated Show resolved Hide resolved
src/components/Semester.vue Outdated Show resolved Hide resolved
@rmz38
Copy link
Contributor Author

rmz38 commented Sep 20, 2020

Still need to add:

  • Showing walkthrough on desktop even if first used on mobile
  • Replace clipboard emoji with svg
  • Tooltips that show up the first time using a feature if design requires it

Copy link
Member

@handotdev handotdev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's try to keep the PR sizes smaller in the future. We could work out the walkthrough in steps and just have some way to gate out the incompleted features. Got some change requests here. But great job overall!

src/assets/scss/introjs.scss Show resolved Hide resolved
src/components/Dashboard.vue Outdated Show resolved Hide resolved
src/components/Dashboard.vue Show resolved Hide resolved
src/components/Dashboard.vue Outdated Show resolved Hide resolved
src/components/Dashboard.vue Show resolved Hide resolved
src/components/Dashboard.vue Outdated Show resolved Hide resolved
src/components/Modals/Onboarding.vue Outdated Show resolved Hide resolved
src/components/Modals/TourWindow.vue Show resolved Hide resolved
src/components/Requirements.vue Outdated Show resolved Hide resolved
src/components/Semester.vue Show resolved Hide resolved
Copy link
Member

@willespencer willespencer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is great! Just left a few comments about some small things to resolve first before merging, and replied to a few of Han's.

Also, just wanted to mention that the actual walkthrough modals are a bit off from the designs. The font, the padding, and the button styling are all a bit off, and the step counter ('1/4', '2/4', etc) is missing from each modal. No need to worry about that until this pull request is merged in since the functionality is all there, but let's talk about when & how to resolve those 😄.

src/components/Dashboard.vue Outdated Show resolved Hide resolved
src/components/Dashboard.vue Show resolved Hide resolved
src/components/Dashboard.vue Show resolved Hide resolved
src/components/Modals/TourWindow.vue Outdated Show resolved Hide resolved
src/components/Requirements.vue Show resolved Hide resolved
Copy link
Member

@willespencer willespencer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome! Just fix the merge conflict and then it can be merged in!

Copy link
Member

@handotdev handotdev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@rmz38 rmz38 merged commit bd59a9d into master Oct 4, 2020
@rmz38 rmz38 deleted the walkthrough branch October 4, 2020 01:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants