Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix batch_symeig cuda index issue #547

Merged
merged 1 commit into from Mar 2, 2019
Merged

Fix batch_symeig cuda index issue #547

merged 1 commit into from Mar 2, 2019

Conversation

@Balandat
Copy link
Collaborator

Balandat commented Mar 2, 2019

type_as does not retain the cuda device index, so the output for small matrices (cpu computation) will be on the default cuda device rather than the one of the input matrix.

type_as does not retain the cuda device index, so the output for small
matrices (cpu computation) will be on the default cuda device rather
than the one of the input matrix.
@Balandat Balandat added the bug label Mar 2, 2019
@Balandat

This comment has been minimized.

Copy link
Collaborator Author

Balandat commented Mar 2, 2019

@gpleiss, @jacobrgardner I wouldn't be surprised if there were other places in the code where this type_as behavior is relevant.

@Balandat Balandat merged commit 645790e into master Mar 2, 2019
1 check passed
1 check passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@Balandat Balandat deleted the fix_batch_symeig_cuda branch Mar 2, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
1 participant
You can’t perform that action at this time.