Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

No reset of counter for risk contacts after two weeks #911

Closed
ehambuch opened this issue Jul 22, 2020 · 29 comments
Closed

No reset of counter for risk contacts after two weeks #911

ehambuch opened this issue Jul 22, 2020 · 29 comments
Assignees
Labels
mirrored-to-jira This item is also tracked internally in JIRA

Comments

@ehambuch
Copy link

ehambuch commented Jul 22, 2020

My app shows "Low risk" (green) with "2 risks contacts" for more than two weeks now!

I would expect that the "risk contacts" would decrease to 0 after a certain period (2 weeks?).

Timeline:
Possible event with crowd of people - 26th Jun (?)
2 risk contacts diplayed in app - since 4th July
No update since then (phone has been restarted)

Regards


Internal Tracking ID: EXPOSUREAPP-1837

@ehambuch ehambuch changed the title No reset of ounter for risk contacts after two weeks No reset of counter for risk contacts after two weeks Jul 22, 2020
@SebastianWolf-SAP
Copy link
Member

SebastianWolf-SAP commented Jul 23, 2020

Probably related to https://github.com/corona-warn-app/cwa-backlog/issues/23, but we need to check if this is also already addressed or not. Until we have certainly, we will keep this issue open.

Mit freundlichen Grüßen/Best regards,
SW
Corona Warn-App Open Source Team

@ehambuch
Copy link
Author

ehambuch commented Jul 23, 2020

coronaapp

Screenshot angefügt.

@akuckartz
Copy link

akuckartz commented Jul 30, 2020

I had 3 "Risiko-Begegnungen" on July 12. Between then and now that number dropped to 2 and 1 later. But it now is still at 1.

@k5e
Copy link

k5e commented Aug 1, 2020

On 2nd of July, I received a contact warning. It stays until today, 1st of August. I checked the keys and there is one "positive" hash that is logged repeatedly until 16th of July. After that no further records with number of hits >0 are there. The app insists on the assertion "1 Risiko-Begegnung".

@ehambuch
Copy link
Author

ehambuch commented Aug 1, 2020

Peeking into the source code, I assume that the ExposureSummary is never cleared (see ExposureSummaryDao). That could be a reason why the counter is not resetted.

@daimpi
Copy link

daimpi commented Aug 2, 2020

Someone on Twitter asked me to post their experience: they have the same problem with a "Risk-Contact but green" status persisting for 14 days now: https://twitter.com/Hckeck/status/1289833171828084737

Their system:
Android 6.0.1
CWA 1.1.1
"Prioritized Background" activated

This might indeed be an Android exclusive problem, as almost simultaneously someone under iOS was reporting that their number of risk encounters was reset to 0.

@akuckartz
Copy link

akuckartz commented Aug 2, 2020

My number of "Riskobegegungen" yesterday has increased from 1 to 2. Due to this bug I distrust the number.

@AFA-start
Copy link

AFA-start commented Aug 10, 2020

Have the same issue: After 16 days there are still "2 Risikobegegnungen" in green > low risk.
I use an Pixel 3a with Android 10
Regards
Arne

@pwoessner
Copy link
Contributor

pwoessner commented Aug 10, 2020

Hi all,

we addressed this issue in this commit here:
90e9a6a

Indeed, there was an issue with using the persisted ExposureSummary instead of the ExposureSummary directly from ENF.
It is currently planned to ship this fix with 1.3.

Thanks,
Philipp

@AFA-start
Copy link

AFA-start commented Aug 10, 2020

Hi Philipp,
thank you for letting us know.
Is there a roadmap/timetable for the release date of version 1.3?

Regards
Arne

@pwoessner
Copy link
Contributor

pwoessner commented Aug 10, 2020

@AFA-start
sorry for the complete confusion. I asked another colleague and this was unfortunately not part of v1.2.0 yet.
But it is indeed part of the v1.3.0 RC1 release:
https://github.com/corona-warn-app/cwa-app-android/releases/tag/1.3.0-SNAPSHOT-RC1

But for this version (1.3.0) I also do not have an ETA but since we already build the RC and testing has started we hope we can publish this release asap.

Thanks,
Philipp

@AFA-start
Copy link

AFA-start commented Aug 10, 2020

Hi @pwoessner,
thanks again. The big questions now is: Does the app still work or do it stuck in an old data set? In other words: Will new encounters be recognized?
Thank you so much for yor time!!!
I realy appricate this!
Arne

@pwoessner
Copy link
Contributor

pwoessner commented Aug 10, 2020

Hi @AFA-start
no the app is never stuck in an old data set. The behaviour is like this:

  • CWA downloads the infected keys
  • The ENF will check if there are exposures
  • If there was a match/exposure, the app will persist the exposure summary (details about the exposue)
  • the risk calculation will use the last persisted exposure summary and will display these values to the user

At the moment this exposure summary will then be used if there is no new match from the Google ENF. But if there is a new exposure the old exposure summary will no longer be used and the new one will be displayed to the user.

Regards,
Philipp

@wilhelmrichter
Copy link

wilhelmrichter commented Aug 26, 2020

"1 Risikobegegnung.." wurde nie geloescht.
Gerät: Samsung G990F ; Kernel 3.4.0 (2016-05-31) ; Android 6.0.1
So wird das nichts mit der Akzeptanz in der Bevölkerung.
Erfahrene Projektentwickler hätten es übrigens wissen müssen. SAP hat noch nie was Ordentliches auf die Beine gestellt. Wer erinnert sich nicht an das total zum Stillstand gebrachte VW-Werk in Kassel, weil die SAP-Leichtmatrosen selbst einfachste Module nicht hinbekommen haben? Dies nur als highlight, ganz zu schweigen von dem auf den Leim gegangenen Mittelstand. Beispiele sind aus den 1990er Jahren. Nicht das die SAP-Hausjuristen mir noch ob der aktuellen Fälle am Zeug flicken...
Vielleicht hätte man 'mal bei den Leutchen von IBM anfragen sollen, oder Oracle oder, oder.
Die App ist mit diesem Anfängerfehler (sieht doch wirklich verdammt nach einem Indexfehler aus) jedenfalls etwas für die Tonne.

@vaubaehn
Copy link
Contributor

vaubaehn commented Aug 26, 2020

Guten Abend @wilhelmrichter ,
vermutlich würden sich alle freuen, wenn Sie sich konstruktiv einbringen. So könnten Sie beispielsweise den Indexfehler im Programmcode identifizieren und korrigieren, und einen der Community Manager darum bitten, Ihren korrigierten Code überprüfen und in die Anwendung übernehmen zu lassen.
Anschuldigungen helfen uns hier leider nicht weiter.
Vielen Dank für Ihre Unterstützung,
V. (ein normaler Nutzer)

@svengabr
Copy link
Member

svengabr commented Aug 27, 2020

As @pwoessner already mentioned a while ago this issue is fixed with the upcoming release 1.3.0.

The RC1 is already available:
https://github.com/corona-warn-app/cwa-app-android/releases/tag/1.3.0-SNAPSHOT-RC1

I will come back to close this issue once the update went live.

Best regards,
SG

Corona-Warn-App Open Source Team

@GisoSchroederSAP
Copy link

GisoSchroederSAP commented Aug 29, 2020

"1 Risikobegegnung.." wurde nie geloescht.
Gerät: Samsung G990F ; Kernel 3.4.0 (2016-05-31) ; Android 6.0.1
So wird das nichts mit der Akzeptanz in der Bevölkerung.
Erfahrene Projektentwickler hätten es übrigens wissen müssen. SAP hat noch nie was Ordentliches auf die Beine gestellt. Wer erinnert sich nicht an das total zum Stillstand gebrachte VW-Werk in Kassel, weil die SAP-Leichtmatrosen selbst einfachste Module nicht hinbekommen haben? Dies nur als highlight, ganz zu schweigen von dem auf den Leim gegangenen Mittelstand. Beispiele sind aus den 1990er Jahren. Nicht das die SAP-Hausjuristen mir noch ob der aktuellen Fälle am Zeug flicken...
Vielleicht hätte man 'mal bei den Leutchen von IBM anfragen sollen, oder Oracle oder, oder.
Die App ist mit diesem Anfängerfehler (sieht doch wirklich verdammt nach einem Indexfehler aus) jedenfalls etwas für die Tonne.

Guten Abend @wilhelmrichter ;
Ich möchte mich den Tenor der anderen Leser und User anschließen und verweise vorsorglich auf den Code of Conduct https://github.com/corona-warn-app/cwa-documentation/blob/master/CODE_OF_CONDUCT.md.

Ihre persönliche Bewertung anderer Aktivitäten der SAP vor vielen Jahren ist für die Entwicklung der Corona Warn App weder hilfreich noch respektvoll. Eine solche Meinungsäußerung in diesem Repository lehnen wir ab.

Daher bitte ich Sie, sich hier künftig sachlich und ziel-orientiert im Sinne der Community zu äußern.
Vorab vielen Dank dafür.

@ehambuch
Copy link
Author

ehambuch commented Sep 6, 2020

Bug is fixed. The counter is now back to zero with V1.3.

@akuckartz
Copy link

akuckartz commented Sep 6, 2020

Finally this is fixed. But I think that this took far to long.

@mtb77
Copy link
Member

mtb77 commented Sep 6, 2020

@ehambuch can we close the issue then?

Thanks,

Sascha

Corona-Warn-App Open Source Team

@ehambuch ehambuch closed this as completed Sep 7, 2020
@wilhelmrichter
Copy link

wilhelmrichter commented Sep 7, 2020

@mgerlach
Copy link

mgerlach commented Sep 8, 2020

I got the update to 1.3.0 recently. For me the counter has not been reset. It's been 1 for weeks now and is still showing one low risk encounter.
Phone: SM-G930F, Android 8.0.0, Basisband G930FXXS8ETC4, Build R16NW.G930FXXS8ETC6, Kernel 3.18.91-14843133-QB29774695 (Mar 10, 2020)

@daimpi
Copy link

daimpi commented Sep 8, 2020

@mgerlach on which date did the encounter first show up for you? Would you maybe share your ENF log? 🙂

@mgerlach
Copy link

mgerlach commented Sep 8, 2020

Must have been around July 18. Where can I find the log?

@daimpi
Copy link

daimpi commented Sep 8, 2020

Where can I find the log?

On your phone's main screen: settings -> Google -> COVID-19 exposure notifications
click on the field where it says "checks performed in the last 14 days", this will bring you to a long list. You can export his list by clicking on the burger menu in the top right corner of the screen and select export.
To share the file here on GH, either rename the .json file to a .txt file or put it in a .zip archive.

@mgerlach
Copy link

mgerlach commented Sep 8, 2020

Thanks. Here it is: https://drive.google.com/file/d/1u5qfIBPvx0f1yQ8OfEa8E04rWu4c0i_b/view?usp=drivesdk

@daimpi
Copy link

daimpi commented Sep 8, 2020

Thanks 🙂
I just scanned your ENF log with https://felixlen.github.io/ena_log/ and got the following output:
grafik

This would indicate that you should have seen this match for the first time around Sept 5th. Does this sound plausible to you?

@mgerlach
Copy link

mgerlach commented Sep 8, 2020

Yes, it does. So I got the app update a few days ago and it probably fixed the issue with the encounter in July, but there must have been an actual low risk encounter 4 days ago, too. I'll keep an eye on this. Thanks for checking!

@daimpi
Copy link

daimpi commented Sep 8, 2020

Ok nice 👍

Keep us posted how it goes with the new encounter 🙂.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
mirrored-to-jira This item is also tracked internally in JIRA
Projects
None yet
Development

No branches or pull requests