Skip to content
This repository has been archived by the owner on Jun 20, 2023. It is now read-only.

Update mapping of app config (EXPOSUREAPP-10446) #4336

Conversation

jurajkusnier
Copy link
Contributor

@jurajkusnier jurajkusnier added the maintainers Tag pull requests created by maintainers label Nov 5, 2021
@jurajkusnier jurajkusnier added this to the 2.13.0 milestone Nov 5, 2021
@jurajkusnier jurajkusnier requested a review from a team November 5, 2021 13:37
@sonarcloud
Copy link

sonarcloud bot commented Nov 5, 2021

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

100.0% 100.0% Coverage
0.0% 0.0% Duplication

@vaubaehn
Copy link
Contributor

vaubaehn commented Nov 5, 2021

@jurajkusnier
Thanks for working on this. Do you have any idea what is a realistic number of additional entries to the app config, especially when other EU countries add/provide a long range of entries? Do you expect any impact on performance, especially for old mobiles?
/cc: @mlenkeit @thomasaugsten

@jurajkusnier
Copy link
Contributor Author

@jurajkusnier Thanks for working on this. Do you have any idea what is a realistic number of additional entries to the app config, especially when other EU countries add/provide a long range of entries? Do you expect any impact on performance, especially for old mobiles? /cc: @mlenkeit @thomasaugsten

We do not currently expect a long range of entries in the app config. So the impact on performance should be minimal even for old devices.

@mtwalli mtwalli self-assigned this Nov 8, 2021
@jurajkusnier jurajkusnier merged commit 2dfa7c4 into feature/10238-invalidate-fake-certificates Nov 8, 2021
@jurajkusnier jurajkusnier deleted the feature/10446-mapping_update branch November 8, 2021 09:35
@vaubaehn
Copy link
Contributor

vaubaehn commented Nov 8, 2021

Hi @jurajkusnier , thanks for your reply! Fingers crossed 🤞 - have a good week!

@mlenkeit
Copy link
Member

mlenkeit commented Nov 8, 2021

@jurajkusnier Thanks for working on this. Do you have any idea what is a realistic number of additional entries to the app config, especially when other EU countries add/provide a long range of entries? Do you expect any impact on performance, especially for old mobiles? /cc: @mlenkeit @thomasaugsten

@vaubaehn this is not designed to be a permanent solution. There are parallel works going on on EU level for a more scalable solution.

@vaubaehn
Copy link
Contributor

vaubaehn commented Nov 8, 2021

@vaubaehn this is not designed to be a permanent solution. There are parallel works going on on EU level for a more scalable solution.

@mlenkeit thanks for the information. Sounds interesting!

mtwalli added a commit that referenced this pull request Nov 10, 2021
* Add ToDo

* add blockListParameters (#4336)

* Update certificate validation logic (EXPOSUREAPP-10447) (#4340)

* add blockListParameters

* implement BlocklistValidator

* lint fix

* fix test

* update DccStateChecker

* lint fix

* update QR code blocked certificates

* better CwaCovidCertificate.State equality check

* handle qr code scanning

* fix tests

* fix tests

* update BlocklistValidator

* test update

* update error dialog

* update error dialog

* test update

* Disable exporting of Blocked Certs(EXPOSUREAPP-10449) (#4351)

* Disable exporting

* Fix Screenshots tests

* disable

* Disable validity check

* remove error dialog when scanning the blocked certificate

* UI update (#4352)

* fix test

* Blocked certs notifications (EXPOSUREAPP-10448) (#4347)

* Notify when blocked

* Update tests

* Cover recovery repo tests

* Update recovery Repo tests

* Update Vaccination Repo tests

* Booster rule storing

* Lint

* Test Repo tests

Co-authored-by: Mohamed Metwalli <mohamed.metwalli@sap.com>

* remove unused strings

* show blocked qr code in details

* fix lint

Co-authored-by: Juraj Kusnier <jurajkusnier@gmail.com>
Co-authored-by: Juraj Kusnier <jurajkusnier@users.noreply.github.com>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
maintainers Tag pull requests created by maintainers
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants