Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Notification about new Risk Status shows when App is open (EXPOSUREAPP-10764) #4673

Merged
merged 9 commits into from Jan 13, 2022
Merged

Notification about new Risk Status shows when App is open (EXPOSUREAPP-10764) #4673

merged 9 commits into from Jan 13, 2022

Conversation

mtwalli
Copy link
Contributor

@mtwalli mtwalli commented Jan 10, 2022 •
edited

Testing

  • Use test menu to change risk level
  • Notice that notification is triggered now in foreground
  • To test the badge, it is a little bit tricky ,since you will land in home screen anyway after test menu

Ticket

https://jira-ibs.wbs.net.sap/browse/EXPOSUREAPP-10764

@mtwalli mtwalli added enhancement Improvement of an existing feature maintainers Tag pull requests created by maintainers labels Jan 10, 2022
@mtwalli mtwalli added this to the 2.17.0 milestone Jan 10, 2022
@mtwalli mtwalli marked this pull request as ready for review January 10, 2022 13:47
@mtwalli mtwalli requested a review from a team January 10, 2022 13:47
@chiljamgossow chiljamgossow self-assigned this Jan 11, 2022
@AlexanderAlferov AlexanderAlferov self-assigned this Jan 11, 2022
AlexanderAlferov
AlexanderAlferov previously approved these changes Jan 11, 2022
View reviewed changes
Copy link
Contributor

@AlexanderAlferov AlexanderAlferov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ Notification in foreground
✅ Notification badge over "Status" icon

@sonarcloud
Copy link

sonarcloud bot commented Jan 12, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 1 Code Smell

81.8% 81.8% Coverage
0.0% 0.0% Duplication

chiljamgossow
chiljamgossow approved these changes Jan 13, 2022
View reviewed changes
Copy link
Contributor

@chiljamgossow chiljamgossow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mtwalli mtwalli merged commit 0976c88 into release/2.17.x Jan 13, 2022
11 checks passed
@mtwalli mtwalli deleted the feature/10764-risk-status-app-is-open branch January 13, 2022 13:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chiljamgossow chiljamgossow chiljamgossow approved these changes

@AlexanderAlferov AlexanderAlferov AlexanderAlferov approved these changes

Assignees

@chiljamgossow chiljamgossow

@AlexanderAlferov AlexanderAlferov

Labels
enhancement Improvement of an existing feature maintainers Tag pull requests created by maintainers
Projects
None yet
Milestone
2.17.0
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@mtwalli @chiljamgossow @AlexanderAlferov