Skip to content
This repository has been archived by the owner on Jun 20, 2023. It is now read-only.

Missing default action for "More Information" button in EN Error popup #1353

Closed
1 task done
ndegendogo opened this issue Oct 15, 2020 · 15 comments
Closed
1 task done
Assignees
Labels
bug Something isn't working mirrored-to-jira This item is also tracked internally in JIRA

Comments

@ndegendogo
Copy link
Contributor

ndegendogo commented Oct 15, 2020

Avoid duplicates

  • [] Bug is not mentioned in the FAQ
  • Bug is not already reported in another issue

Describe the bug

When ENF reports an error code, this is shown as dialog box to the user, with buttons "ok" and "Mehr erfahren". But in some cases, the "mehr erfahren" button is empty. Example: EN error 2 (bad params). See here
I agree that there is not much a user can do if they encounter such an error. But at least they should report back so it can be investigated and fixed.

Expected behaviour

Button "mehr erfahren" should always give some advice. If no specific action is recommended, the user should at least report back to the technical hotline or to the project maintainers at github.

Steps to reproduce the issue

  • Trigger an EN error like error 2
  • see the dialog box
  • press button "mehr erfahren"

Technical details

cwa 1.3.2(0)

  • iOS Version:
  • Device:

Possible Fix

Additional context


Internal Tracking ID: EXPOSUREAPP-3286

@ndegendogo ndegendogo added the bug Something isn't working label Oct 15, 2020
@Ein-Tim
Copy link
Contributor

Ein-Tim commented Oct 15, 2020

@ndegendogo
I also think it would be good to have the "More Information" button working, but since the EN Error comes from the ENF, I think the Pop Up also comes from Apple and the Devs here can't do anything about it.
Just wanted to add that 🙂

@tens0rfl0w
Copy link
Contributor

@Ein-Tim If I remember correctly from a earlier pre-release development stage the error gets returned as a conditional return when the API entry point functions are called, so the alert popup is handled by the app. With that it's possible to handle every error appropriate.

@Ein-Tim
Copy link
Contributor

Ein-Tim commented Oct 15, 2020

@tens0rfl0w
Okay, as said this was only an assumption but thanks for your comment 👍 Lets wait for the Devs and see what say

@tens0rfl0w
Copy link
Contributor

tens0rfl0w commented Oct 15, 2020

Actually found the PR that I had in mind: #868

This was the latest addition to UI error handling. Looking at the code you can see that the error handling is handled by the app itself and that there is just no special case for Error 2 as it never happened before. Should be an easy one to fix this. :)

@heinezen heinezen changed the title Default action for EN Error Default action for "More Information" button in EN Error popup Oct 15, 2020
@heinezen heinezen changed the title Default action for "More Information" button in EN Error popup Missing default action for "More Information" button in EN Error popup Oct 15, 2020
@heinezen
Copy link
Member

Hello everyone,

The issue is now mirrored to Jira (ticket ID: EXPOSUREAPP-3286). Let's see what the devs can do about it. Further updates on the progress will be posted in this thread.

@ndegendogo I changed your title to be more precise. Hope that is okay with you.

Regards,
CH


Corona-Warn-App Open Source Team

@heinezen heinezen added the mirrored-to-jira This item is also tracked internally in JIRA label Oct 15, 2020
@dsarkar
Copy link
Member

dsarkar commented Dec 1, 2020

Dear community,

we also updated info for developers with respect to this issue. Best,
DS


Corona-Warn-App Open Source Team

@dsarkar
Copy link
Member

dsarkar commented Dec 1, 2020

See #1000 (comment)

@Ein-Tim
Copy link
Contributor

Ein-Tim commented Dec 23, 2020

Although this is solved, I again looked at the PR which @tens0rfl0w shared here a few months ago (#868).
When looking at this file, there, in line 23, the General_moreInfo_URL is defined so that it points to https://www.coronawarn.app/de/faq/.

If I understand everything correct here this means that all ENErrors (but 5, 11 and 13) should guide the user to https://www.coronawarn.app/de/faq/, or?

@dsarkar
Copy link
Member

dsarkar commented Dec 28, 2020

@Ein-Tim, We will check with the developers. Thanks, DS


Corona-Warn-App Open Source Team

@dsarkar
Copy link
Member

dsarkar commented Jan 21, 2021

@Ein-Tim

If I understand everything correct here this means that all ENErrors (but 5, 11 and 13) should guide the user to https://www.coronawarn.app/de/faq/, or?

Feedback from developers: That is correct.

@ndegendogo Feel free to close this issue.

Thanks to everybody.

@Ein-Tim
Copy link
Contributor

Ein-Tim commented Jan 21, 2021

No please don't close this.
The PR #868 was merged on the 08.07.2020.
This Issue was opened on the 15.10.2020.
@dsarkar could the devs please check if this really works?

@heinezen
Copy link
Member

@Ein-Tim The latest change was in #1608 which suppresses the error messages and handle the error internally. This is the recommended procedure for all ENErrors as far as I know. The app will cach these error and display its own message popup with links to the FAQ.


Corona-Warn-App Open Source Team

@Ein-Tim
Copy link
Contributor

Ein-Tim commented Jan 24, 2021

Thanks @heinezen.
Can be closed from my side.

@dsarkar
Copy link
Member

dsarkar commented Jan 28, 2021

@Ein-Tim regarding errors 5,11,13 and the rest of them and your question #1353 (comment) got the following answer from the developers:

Yes, it is currently implemented in this way. Errors that occur or are known are linked to a specific FAQ entry to help the user. Error codes that exist theoretically but have never occurred before are linked to the FAQ overview. If one of these errors occurs, the URL can be quickly adjusted.

@dsarkar dsarkar added the ready to close The issue is ready to be closed. label Jan 28, 2021
@Ein-Tim
Copy link
Contributor

Ein-Tim commented Jan 28, 2021

Okay thanks. Can be closed 👍

@dsarkar dsarkar removed the ready to close The issue is ready to be closed. label Jan 29, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Something isn't working mirrored-to-jira This item is also tracked internally in JIRA
Projects
None yet
Development

No branches or pull requests

6 participants