Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix/dont show allready running alert #1510

Merged
merged 7 commits into from Nov 16, 2020

Conversation

ArturFriesen
Copy link
Contributor

Description

This PR prevents the alert for already running error.

Link to Jira

3769

@ArturFriesen ArturFriesen requested a review from a team as a code owner Nov 13, 2020
@marcussc
Copy link
Contributor

Labels please :)

@ArturFriesen ArturFriesen added the bug Something isn't working label Nov 13, 2020
@ArturFriesen ArturFriesen added this to the v1.7.0 milestone Nov 13, 2020
dsarkar added a commit to corona-warn-app/cwa-website that referenced this pull request Nov 16, 2020
EN
                   {
                        "title": "[Apple/iOS] 'ExposureDetectionIsAlreadyRunning' in CWA version 1.6.1",
                        "anchor": "ExposureDetectionIsAlreadyRunning",
                        "active": true,
                        "textblock": [
                            "The notification <a href='https://github.com/corona-warn-app/cwa-app-ios/issues/1497'>'ExposureDetectionIsAlreadyRunning'</a> <a href='https://github.com/corona-warn-app/cwa-app-ios/issues/1512#issuecomment-727206633'>can be ignored</a>. The CWA is still working correctly and this issue will be solved with a <a href='https://github.com/corona-warn-app/cwa-app-ios/pull/1510'>future release</a>."
                        ]
                    },

DE

                   {
                        "title": "[Apple/iOS] 'ExposureDetectionIsAlreadyRunning' in CWA version 1.6.1",
                        "anchor": "ExposureDetectionIsAlreadyRunning",
                        "active": true,
                        "textblock": [
                            "Die Meldung <a href='https://github.com/corona-warn-app/cwa-app-ios/issues/1497'>'ExposureDetectionIsAlreadyRunning'</a> <a href='https://github.com/corona-warn-app/cwa-app-ios/issues/1512#issuecomment-727206633'>kann ignoriert werden</a>. Die CWA funktioniert korrekt und dieses Problem wird in einem <a href='corona-warn-app/cwa-app-ios#1510'> bevorstehenden Update korrigiert</a>."
                        ]
                    },
} else if let exposureDetectionError = noSummaryError as? ExposureDetectionError {
switch exposureDetectionError {
case .isAlreadyRunning:
return nil
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Doesn't the error also trigger a different cell on the home view? Should we throw this error at all?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very good point!
Currently it cannot happen, because RiskProvider "guards" this case for the key download and the risk detection.
But I think it is still a valid point from the perspective of code readability.
I have added error handling to HomeInteractor which explicitly ignores the allready running errors.

# Conflicts:
#	src/xcode/ENA/ENA/Source/Services/Risk/Provider/RiskProvider.swift
@marcussc marcussc merged commit 76e5b57 into release/1.7.x Nov 16, 2020
@marcussc marcussc deleted the fix/Dont_Show_AllreadyRunning_Alert branch Nov 16, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants