Fix/dont show allready running alert #1510
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Remove misleading comment.
2 tasks
|
Labels please :) |
marcussc
approved these changes
Nov 13, 2020
This was referenced Nov 14, 2020
dsarkar
added a commit
to corona-warn-app/cwa-website
that referenced
this pull request
Nov 16, 2020
EN
{
"title": "[Apple/iOS] 'ExposureDetectionIsAlreadyRunning' in CWA version 1.6.1",
"anchor": "ExposureDetectionIsAlreadyRunning",
"active": true,
"textblock": [
"The notification <a href='https://github.com/corona-warn-app/cwa-app-ios/issues/1497'>'ExposureDetectionIsAlreadyRunning'</a> <a href='https://github.com/corona-warn-app/cwa-app-ios/issues/1512#issuecomment-727206633'>can be ignored</a>. The CWA is still working correctly and this issue will be solved with a <a href='https://github.com/corona-warn-app/cwa-app-ios/pull/1510'>future release</a>."
]
},
DE
{
"title": "[Apple/iOS] 'ExposureDetectionIsAlreadyRunning' in CWA version 1.6.1",
"anchor": "ExposureDetectionIsAlreadyRunning",
"active": true,
"textblock": [
"Die Meldung <a href='https://github.com/corona-warn-app/cwa-app-ios/issues/1497'>'ExposureDetectionIsAlreadyRunning'</a> <a href='https://github.com/corona-warn-app/cwa-app-ios/issues/1512#issuecomment-727206633'>kann ignoriert werden</a>. Die CWA funktioniert korrekt und dieses Problem wird in einem <a href='corona-warn-app/cwa-app-ios#1510'> bevorstehenden Update korrigiert</a>."
]
},
KaiTeuber
approved these changes
Nov 16, 2020
nickguendling
requested changes
Nov 16, 2020
| } else if let exposureDetectionError = noSummaryError as? ExposureDetectionError { | ||
| switch exposureDetectionError { | ||
| case .isAlreadyRunning: | ||
| return nil |
There was a problem hiding this comment.
Doesn't the error also trigger a different cell on the home view? Should we throw this error at all?
There was a problem hiding this comment.
Very good point!
Currently it cannot happen, because RiskProvider "guards" this case for the key download and the risk detection.
But I think it is still a valid point from the perspective of code readability.
I have added error handling to HomeInteractor which explicitly ignores the allready running errors.
nickguendling
approved these changes
Nov 16, 2020
# Conflicts: # src/xcode/ENA/ENA/Source/Services/Risk/Provider/RiskProvider.swift
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Description
This PR prevents the alert for already running error.
Link to Jira
3769