This repository has been archived by the owner on May 16, 2023. It is now read-only.
Add block list for DCCs - HF #1602
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mlenkeit
reviewed
Nov 5, 2021
|
|
||
| message DGCBlockedUVCIChunk { | ||
| repeated uint32 incides = 1; |
There was a problem hiding this comment.
@ioangut can you update this to the version from https://github.com/corona-warn-app/cwa-server/pull/1595/files? It fixes a typo here: incides -> indices
mlenkeit
suggested changes
Nov 5, 2021
| # generate the individual items, e.g. | ||
| # '[{"indices":[0],"hash":"fcde2b2edba5"},{"indices":[0,2],"hash":"1b68fbf8fb94"}]' | ||
| # note that `hash` shall be parsed from a hex string to a byte sequence | ||
| blocked-uvci-chunks: ${DGC_BLOCKED_UVCI_CHUNKS:[{"indices":[0],"hash":"9B09CAFEC0A6808411C348880C9C2D920646DFB980B5C959DC6EBF8A19B98120","validFrom":1636040446},{"indices":[0,2],"hash":"7D5D5B336E903086D64D1207EC6E957A4B1301026699011026F84A5156317C2B","validFrom":1638369640}]} |
There was a problem hiding this comment.
@ioangut that's the default value for PROD then, right? Default should be empty array...
| return deserializedBlockedUvciChunks.stream().filter(dgcBlockedUvciChunk -> | ||
| TimeUtils.getNow().getEpochSecond() >= dgcBlockedUvciChunk.getValidFrom()) | ||
| .map(deserializedBlockedUvciChunk -> DGCBlockedUVCIChunk.newBuilder() | ||
| .addAllIncides(deserializedBlockedUvciChunk.getIndices()) |
There was a problem hiding this comment.
I guess this will need to be adjusted for the typo once the ProtoBuf is updated.
|
Kudos, SonarCloud Quality Gate passed! |
AliceBilc
approved these changes
Nov 5, 2021
CManole
approved these changes
Nov 5, 2021
ioangut
added a commit
that referenced
this pull request
Nov 8, 2021
* Add block list for DCCs * add test and change default value
ioangut
added a commit
that referenced
this pull request
Nov 11, 2021
* Add luca app tracing parameters * Add block list for DCCs - HF (#1602) * Add block list for DCCs * add test and change default value
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.