Skip to content
This repository has been archived by the owner on May 16, 2023. It is now read-only.

Add Google-Style IntelliJ formatter settings to .editor.conf #397

Merged
merged 3 commits into from Jun 2, 2020

Conversation

michael-burwig
Copy link
Member

No description provided.

charset = utf-8
end_of_line = lf
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

FYI - On Windows, files checked out by git start out with CRLF line ending by default, but then due to this setting, get converted to LF (at least by my Windows InteliJ IDE) upon modifying and saving a file. However, this doesn't seem to cause any trouble as Windows InteliJ is probably smart enough to handle LF fine as well. And as we've already had this (end_of_line) in for a while and some of us are Windows users, this is probably safe to keep.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@stevesap You may eventually want to configure core.autocrlf for that repository to make git enforce a certain line ending style: https://git-scm.com/book/en/v2/Customizing-Git-Git-Configuration (in case you don't trust the IDE or use other editors additionally).

.editorconfig Outdated Show resolved Hide resolved
@michael-burwig michael-burwig force-pushed the admin/add-intellij-params-in-editorconf branch 9 times, most recently from 053b7e9 to 410ac81 Compare June 2, 2020 18:58
@michael-burwig michael-burwig force-pushed the admin/add-intellij-params-in-editorconf branch from 410ac81 to 7889cee Compare June 2, 2020 19:57
@sonarcloud
Copy link

sonarcloud bot commented Jun 2, 2020

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities (and Security Hotspot 0 Security Hotspots to review)
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

Copy link
Contributor

@stevesap stevesap left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@stevesap stevesap merged commit 20492aa into master Jun 2, 2020
@stevesap stevesap deleted the admin/add-intellij-params-in-editorconf branch June 2, 2020 21:15
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants