Skip to content
This repository has been archived by the owner on May 16, 2023. It is now read-only.

fix: correct registration key validation #163

Merged

Conversation

simonresch
Copy link
Contributor

This PR fixes an issue where registration keys ending with a new line character after 64 valid characters would be incorrectly validated, triggering an unsuccessful database write with a 500 response code.

I found this test case using CI Fuzz by code-intelligence.

This is needed to invalidate keys that end with a
new line character.
@daniel-eder daniel-eder added the in review Moderators are investigating how to best proceed with the issue label Jun 16, 2020
Copy link
Contributor

@alstiefel alstiefel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thx a lot for your contribution

@alstiefel alstiefel added this to the 1.0.1 milestone Jun 24, 2020
@alstiefel alstiefel merged commit 6ade86d into corona-warn-app:master Jun 24, 2020
@ascheibal ascheibal added the implemented implemented but not deployed yet label Jul 6, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
implemented implemented but not deployed yet in review Moderators are investigating how to best proceed with the issue
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants