Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Create singular function to get embeddings from Ada. #17

Closed
shivankacker opened this issue Apr 3, 2023 · 2 comments · Fixed by #23
Closed

Create singular function to get embeddings from Ada. #17

shivankacker opened this issue Apr 3, 2023 · 2 comments · Fixed by #23
Assignees
@Ashesh3
Labels
STAGE 1

Comments

@shivankacker
Copy link
Member

shivankacker commented Apr 3, 2023 •
edited
Loading

Currently we are getting embeddings during upsert as well as in the /chat api through a function. Replace the logic of getting embeddings during upsert to also use this function.
Update the logic in the function to convert input into chunks
@Ashesh3 Ashesh3 self-assigned this Apr 4, 2023
@Ashesh3 Ashesh3 mentioned this issue Apr 4, 2023
Merged
@siddnikh
Copy link
Contributor

siddnikh commented Apr 4, 2023

There is one already. I added it earlier, it's in ayushma/utils/openaiapi.py

@Ashesh3
Copy link
Member

Ashesh3 commented Apr 4, 2023

There is one already. I added it earlier, it's in ayushma/utils/openaiapi.py

Looks good, I will refactor the upsert to use the method in utils.

siddnikh added a commit to siddnikh/ayushma that referenced this issue Apr 4, 2023
@siddnikh
Made changes, also solves ohcnetwork#17
0f7e4e0
@Ashesh3 Ashesh3 mentioned this issue Apr 5, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Ashesh3 Ashesh3

Labels
STAGE 1
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Use get_embedding from utils for upsert ohcnetwork/ayushma
3 participants
@Ashesh3 @shivankacker @siddnikh