Added Facility Hubs #2135
Merged
Added Facility Hubs #2135
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rithviknishad
approved these changes
May 8, 2024
sainak
requested changes
May 8, 2024
|
lgtm, |
sainak
reviewed
May 14, 2024
sainak
approved these changes
May 14, 2024
|
@rithviknishad bump |
rithviknishad
approved these changes
May 20, 2024
|
Need to resolve conflicts |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #2135 +/- ##
===========================================
+ Coverage 65.19% 65.32% +0.13%
===========================================
Files 242 242
Lines 13865 13933 +68
Branches 1925 1930 +5
===========================================
+ Hits 9039 9102 +63
- Misses 4448 4451 +3
- Partials 378 380 +2 ☔ View full report in Codecov by Sentry. |
vigneshhari
requested changes
Aug 25, 2024
|
LGTM |
vigneshhari
approved these changes
Sep 16, 2024
| check=~models.Q(hub=models.F("spoke")), | ||
| name="hub_and_spoke_not_same", | ||
| ), | ||
| # bidirectional uniqueness |
There was a problem hiding this comment.
This ensures bi directional uniqueness, but it does not make sense to have cyclical dependences
There was a problem hiding this comment.
I think the check is already there in serializers if I am understanding you correctly. I have also added it in the model now. Can you please verify if that is what you meant?
vigneshhari
approved these changes
Sep 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed Changes
Associated Issue
Merge Checklist
/docsOnly PR's with test cases included and passing lint and test pipelines will be reviewed
@coronasafe/care-backend-maintainers @coronasafe/care-backend-admins