Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hihat stomp is weak and cannot be mixed alone #105

Closed
3hhh opened this issue Oct 20, 2023 · 3 comments
Closed

Hihat stomp is weak and cannot be mixed alone #105

3hhh opened this issue Oct 20, 2023 · 3 comments

Comments

@3hhh
Copy link
Contributor

3hhh commented Oct 20, 2023

The hihat stomp output was rather weak during my tests compared to the hihat hits.

This could be fixed by postprocessing it with a mixer; however edrumulus currently uses the same Midi note for a stomp as for a hit on the hihat.

Imho it would be better to use different notes, so that such volume issues can be fixed during postprocessing.
Also, stomping sounds slightly different from hitting a hihat in practice, i.e. one might want to use different samples anyway.

@corrados
Copy link
Owner

There is a separate MIDI not for Hi-Hat stomp action, see

edrumulus.set_midi_notes ( hihatctrl_pad_idx, 44, 44 ); // Hi-Hat pedal hit

@3hhh
Copy link
Contributor Author

3hhh commented Oct 21, 2023

Thanks for the hint!

During my testing I had noticed 4 different notes for the hihat: Two for hits on bow and edge and another two for the open/closed bow/edge variant.
Maybe my stomps aren't detected?
I'll investigate further....

@3hhh
Copy link
Contributor Author

3hhh commented Oct 22, 2023

Maybe my stomps aren't detected?

Yes, they weren't detected. I managed to fix it by setting a high threshold & sensitivity for the control port.

With a lower threshold I could observe my hihat pedal movements on the screen, which was really nice and would easily enable half-open hihat Midi notes, if one wanted to support that feature.

Anyway this particular issue is invalid.

@3hhh 3hhh closed this as completed Oct 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants