Skip to content

feat(config): support explicit tsgo checker#53

Merged
ualtinok merged 2 commits into
cortexkit:mainfrom
chrisolszewski:feat/checker-tsgo-explicit
May 22, 2026
Merged

feat(config): support explicit tsgo checker#53
ualtinok merged 2 commits into
cortexkit:mainfrom
chrisolszewski:feat/checker-tsgo-explicit

Conversation

@chrisolszewski
Copy link
Copy Markdown
Contributor

@chrisolszewski chrisolszewski commented May 21, 2026

Summary

Lets you choose tsgo, the native TypeScript preview compiler, as the TypeScript
checker. Defaults don't change: tsc stays the default, and tsgo runs only when
you ask for it.

What changed

  • format.rs, configure.rs: treat tsgo the same way as tsc where the
    invocation is identical, plus Windows shim detection.
  • Config and schema: add tsgo to the checker enum (opencode and pi), the schema
    asset, and the generator.
  • Docs: README lists tsc as the default and tsgo as an explicit opt-in.
  • Tests: checker selection in configure.

Why opt-in only

tsgo is still a preview build. Making it the default would change type-checking
for every TypeScript project, so it runs only when configured.

Validation

  • cargo fmt --check; cargo test -p agent-file-tools configure
  • bun run typecheck in both plugins

Summary by cubic

Adds opt-in support for tsgo as the TypeScript checker. Defaults remain tsc; nothing changes unless you explicitly configure tsgo.

  • New Features

    • Added tsgo to checker enums and schemas across AFT, opencode and pi plugins.
    • Execute tsgo with the same args as tsc, with Windows shim detection, diagnostic parsing, and consistent checker_command handling (no behavior change).
    • Added install hint for tsgo and tests for selection, diagnostics, and configure warnings.
  • Migration

    • Enable by setting "checker": { "typescript": "tsgo" } in your config.
    • Install @typescript/native-preview (dev or global).

Written for commit 9a96add. Summary will update on new commits. Review in cubic

Copy link
Copy Markdown

@cubic-dev-ai cubic-dev-ai Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

1 issue found across 9 files

Reply with feedback, questions, or to request a fix.

Fix all with cubic | Re-trigger cubic

Comment thread crates/aft/src/format.rs
checker_command relied on the `_ => resolved` catch-all for tsgo, while the rest of the checker path groups `tsc | tsgo` wherever the invocation is identical (explicit_checker_candidate, checker_args, parse_checker_output). Group them here too so the identical-behavior sites read consistently. No behavior change: tsgo already resolved to its binary path via the catch-all.
Copy link
Copy Markdown

@cubic-dev-ai cubic-dev-ai Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No issues found across 9 files

Re-trigger cubic

@ualtinok ualtinok merged commit 54dd893 into cortexkit:main May 22, 2026
10 of 11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants