Skip to content

Improve environment error messages during cortex get #1292

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Aug 24, 2020
Merged

Improve environment error messages during cortex get #1292

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
ea670cf
Update get.go
vishalbollu Aug 24, 2020
7d13486
Update get.go
vishalbollu Aug 24, 2020
599cb7e
Merge branch 'master' into get-all-environments-errors
vishalbollu Aug 24, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
25 changes: 19 additions & 6 deletions cli/cmd/get.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -189,13 +189,26 @@ func getAPIsInAllEnvironments() (string, error) {
out := ""

if len(allRealtimeAPIs) == 0 && len(allBatchAPIs) == 0 && len(allTrafficSplitters) == 0 {
if len(errorsMap) == 1 {
// Print the error if there is just one
exit.Error(errors.FirstErrorInMap(errorsMap))
}
// if all envs errored, skip "no apis are deployed" since it's misleading
// check if any environments errorred
if len(errorsMap) != len(cliConfig.Environments) {
out += console.Bold("no apis are deployed") + "\n"
if len(errorsMap) == 0 {
return console.Bold("no apis are deployed"), nil
}

var successfulEnvs []string
for _, env := range cliConfig.Environments {
if _, ok := errorsMap[env.Name]; !ok {
successfulEnvs = append(successfulEnvs, env.Name)
}
}
fmt.Println(console.Bold(fmt.Sprintf("no apis are deployed in %s: %s", s.PluralS("environment", len(successfulEnvs)), s.StrsAnd(successfulEnvs))) + "\n")
}

// Print the first error
for name, err := range errorsMap {
if err != nil {
exit.Error(errors.Wrap(err, "env "+name))
}
}
} else {
if len(allBatchAPIs) > 0 {
Expand Down