Skip to content

Address nil pointer in K8s Annotations for TrafficSplitter #1293

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Aug 24, 2020
Merged

Address nil pointer in K8s Annotations for TrafficSplitter #1293

merged 1 commit into from
Aug 24, 2020

Conversation

@vishalbollu
Copy link
Contributor

@vishalbollu vishalbollu commented Aug 24, 2020

checklist:

  • run make test and make lint
  • test manually (i.e. build/push all images, restart operator, and re-deploy APIs)
  • update examples
  • update docs and add any new files to summary.md (view in gitbook after merging)
  • cherry-pick into release branches if applicable
  • alert the dev team if the dev environment changed

@vishalbollu vishalbollu requested a review from deliahu August 24, 2020 20:47
@vishalbollu vishalbollu merged commit a22422f into master Aug 24, 2020
@vishalbollu vishalbollu deleted the nil-pointer-k8s-annotations branch August 24, 2020 21:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@deliahu deliahu deliahu approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@vishalbollu @deliahu