Skip to content

Handle nil pointer queue url in manage job cron #1389

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Sep 28, 2020
Merged

Handle nil pointer queue url in manage job cron #1389

Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
96704aa
Update manage_resources_cron.go
vishalbollu Sep 26, 2020
591a798
Update manage_resources_cron.go
vishalbollu Sep 26, 2020
c73d12c
Merge branch 'master' into nil-pointer-batch-api
vishalbollu Sep 28, 2020
a28385e
Merge branch 'master' into nil-pointer-batch-api
vishalbollu Sep 28, 2020
fe76610
Merge branch 'master' into nil-pointer-batch-api
vishalbollu Sep 28, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion pkg/operator/resources/batchapi/manage_resources_cron.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -116,7 +116,6 @@ func ManageJobResources() error {
errors.PrintError(err)
continue
}

if newStatusCode != jobState.Status {
err = errors.FirstError(
writeToJobLogStream(jobKey, msg),
Expand All @@ -128,6 +127,10 @@ func ManageJobResources() error {
continue
}
}
if queueURL == nil {
// job has been submitted within the grace period, it may take a while for a newly created queue to be listed in SQS api response
continue
}

err = checkIfJobCompleted(jobKey, *queueURL, k8sJob)
if err != nil {
Expand Down