Skip to content

Catch operator panics in go routines with sentry #1746

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 10 commits into from
Jan 4, 2021
Merged

Catch operator panics in go routines with sentry #1746

merged 10 commits into from
Jan 4, 2021

Conversation

@RobertLucian
Copy link
Member

@RobertLucian RobertLucian commented Dec 29, 2020 •
edited by deliahu
Loading

checklist:

  • run make test and make lint
  • test manually (i.e. build/push all images, restart operator, and re-deploy APIs)

@RobertLucian RobertLucian requested a review from deliahu December 29, 2020 16:56
deliahu
deliahu reviewed Dec 30, 2020
View reviewed changes
@RobertLucian RobertLucian merged commit f0e389d into master Jan 4, 2021
@RobertLucian RobertLucian deleted the feature/handle-go-routine-panics branch January 4, 2021 14:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@deliahu deliahu deliahu approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@RobertLucian @deliahu