Skip to content

Initialize logger before accessing it #1810

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jan 20, 2021
Merged

Initialize logger before accessing it #1810

merged 2 commits into from
Jan 20, 2021

Conversation

vishalbollu
Copy link
Contributor

@vishalbollu vishalbollu commented Jan 20, 2021 •
edited by RobertLucian
Loading

checklist:

  • run make test and make lint
  • test manually (i.e. build/push all images, restart operator, and re-deploy APIs)

RobertLucian
RobertLucian approved these changes Jan 20, 2021
View reviewed changes
Copy link
Member

@RobertLucian RobertLucian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Just one thing I noticed there.

@vishalbollu vishalbollu merged commit 838d416 into master Jan 20, 2021
@vishalbollu vishalbollu deleted the initialize-logger-where-required branch January 20, 2021 19:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@RobertLucian RobertLucian RobertLucian approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@vishalbollu @RobertLucian