Skip to content

Conversation

@RobertLucian
Copy link
Member

@RobertLucian RobertLucian commented Jun 5, 2021

Since the latency checks don't appear to be 100% reliable during the nightly test due to external factors (the CI box living close or far away from the cluster on different occasions), it's better if we remove them temporarily until a better solution is designed.

We could have loosened the restrictions on what an acceptable latency is, but at the end of the day:

  1. It's probably better if we have a different test (separate from the load test) that's specifically meant for evaluating the quantile values of the latencies in a well-defined manner (needs design).
  2. Same as 1, but embedded in the current load test.

checklist:

  • run make test and make lint
  • test manually (i.e. build/push all images, restart operator, and re-deploy APIs)

@RobertLucian RobertLucian added the tests Something related to testing label Jun 5, 2021
@deliahu deliahu merged commit 212d52c into master Jun 6, 2021
@deliahu deliahu deleted the fix/e2e-without-latencies branch June 6, 2021 16:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

tests Something related to testing

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants