Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add gofmt to make lint-go #23

Merged
merged 10 commits into from Feb 28, 2019

Conversation

Projects
None yet
2 participants
@deliahu
Copy link
Member

deliahu commented Feb 26, 2019


Checklist:

  • Run automated tests (make test)
  • Test end to end manually (e.g. rebuild registry/operator and run cx refresh in an example folder)
  • Add license header to each new file
  • Update documentation
  • Update examples and cx init
  • Alert team if dev environment changed
  • Cherry-pick into release branches if it's a bugfix
  • Delete the branch once it's merged

@deliahu deliahu requested a review from 1vn Feb 26, 2019

@deliahu deliahu force-pushed the gofmt-ci branch 12 times, most recently from 909c896 to 4d8b2ee Feb 26, 2019

@deliahu deliahu force-pushed the gofmt-ci branch from 4d8b2ee to 794b64c Feb 26, 2019

@1vn
Copy link
Member

1vn left a comment

LGTM

@deliahu deliahu force-pushed the gofmt-ci branch from 4ade75a to 9b4b378 Feb 28, 2019

@deliahu deliahu merged commit fc2de06 into master Feb 28, 2019

1 check passed

ci/circleci: test Your tests passed on CircleCI!
Details

@deliahu deliahu deleted the gofmt-ci branch Feb 28, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.